Hi Rodolfo,

Unfortunately, no, I did not check that. I'll try to have a look just in case, 
but if you manage to find time for that too, do not hesitate! On a positive 
note, I do not have any "warning: unused variable" message, so that's a good 
sign...

Regards,
Christophe.


----- Rodolfo García Peñas (kix) <[email protected]> a écrit :
> Hi Christophe,
> 
> did you check if some variables (like WScreen) in the function
> definition are not longer used in the functions of these patches?
> 
> Cheers,
> kix
> 
> Christophe <[email protected]> escribió:
> 
> > From: Christophe CURIS <[email protected]>
> >
> > Hello,
> >
> > It looks like this should be the last changes on global variables
> > that were declared in not so great places.
> >
> > Regards,
> > Christophe.
> >
> >
> >
> > Christophe CURIS (4):
> >   wmaker: Moved variable ValidModMask into the global namespace
> >   wmaker: Moved global domain definition to the global namespace
> >   wmaker: Moved definition of global variable 'wKeyBindings' to header
> >   Added compilation check for dangerous use of 'extern' keyword
> >
> >  configure.ac      |  5 +++++
> >  src/WindowMaker.h | 16 ++++++++++++++--
> >  src/appicon.c     |  7 ++-----
> >  src/cycling.c     |  4 +---
> >  src/defaults.c    | 53 
> > ++++++++++++++++++++++++-----------------------------
> >  src/dialog.c      |  2 --
> >  src/event.c       |  4 +---
> >  src/keybind.h     |  6 ++++++
> >  src/main.c        |  8 +-------
> >  src/rootmenu.c    | 13 ++++++-------
> >  src/screen.c      |  7 +------
> >  src/startup.c     | 26 ++++++++++----------------
> >  src/wdefaults.c   | 35 ++++++++++++++++-------------------
> >  src/window.c      | 14 ++++++--------
> >  src/winmenu.c     |  3 ---
> >  src/winspector.c  |  4 +---
> >  src/workspace.c   |  1 -
> >  17 files changed, 94 insertions(+), 114 deletions(-)
> >
> > --
> > 1.8.4.rc3
> >
> >
> > --
> > To unsubscribe, send mail to [email protected].
> 
> 
> Rodolfo García Peñas (kix)
> http://www.kix.es/


--
To unsubscribe, send mail to [email protected].

Reply via email to