On Fri, 11 Oct 2013 at 22:36:29 +0200, Christophe wrote: > From: Christophe CURIS <[email protected]> > > > On Fri, 11 Oct 2013 12:17:07 +0400, Alexey wrote: > > On Thu, Oct 10, 2013 at 08:38:22PM +0200, Christophe wrote: > > > + Bool ignore_change; > > > -int ignore_wks_change =3D 0; > > Don't you need to initialize w_global.workspace.ignore_change variable? > > Conceptually, yes > Factually, no > > The w_global struct is initialised with 0s (memset), so the behaviour > is correct. But thanks for pointing out! > > Carlos, > You can find an alternate version of the patch that does include the > initialisation if you prefer it this way. As it may break other patches, > I'll send updated versions of them if needed.
I added the initialization line in the original patch and rebased the result. So it should all be fine now. Thanks! -- To unsubscribe, send mail to [email protected].
