----- Doug Torrance <[email protected]> a écrit :
> [...]
>
> -#define MC_MAXIMIZE 0
> -#define MC_MINIATURIZE 1
> -#define MC_SHADE 2
> -#define MC_HIDE 3
> -#define MC_MOVERESIZE 4
> -#define MC_SELECT 5
> -#define MC_DUMMY_MOVETO 6
> -#define MC_PROPERTIES 7
> -#define MC_OPTIONS 8
> -#define MC_SHORTCUT 8
> -#define MC_RELAUNCH 9
> -
> -#define MC_CLOSE 10
> -#define MC_KILL 11
> +#define MC_MAXIMIZE 0
> +#define MC_OTHERMAX 1
> +#define MC_MINIATURIZE 2
> +#define MC_SHADE 3
> +#define MC_HIDE 4
> +#define MC_MOVERESIZE 5
> +#define MC_SELECT 6
> +#define MC_DUMMY_MOVETO 7
> +#define MC_PROPERTIES 8
> +#define MC_OPTIONS 9
> +#define MC_SHORTCUT 9
> +#define MC_RELAUNCH 10
> +#define MC_CLOSE 11
> +#define MC_KILL 12
> +
Hi,
May I suggest to take the opportunity to transform these #define into an enum?
that would make the code easier to work with.
> [...]
>
> + entry = wMenuAddCallback(menu, _("Other maximization options"), NULL,
> NULL);
> + wMenuEntrySetCascade(menu, entry, makeMaximizeMenu(scr));
> +
On personal taste, I would suggest a shorter line "Other maximization" so it
does not stand out too much in the menu compared to the other entries.
Apart from these, I think it's a great idea to bring more visibility to these
capabilities!
Regards,
Christophe.
--
To unsubscribe, send mail to [email protected].
