Hi Daniel, On Tue, 15 Oct 2013, Daniel Déchelotte escribió:
> Hi kix, > > I do believe the current behavior (after this series of patch) is > identical to the old one. At least, when you write: > > > If I move the icon using the Alt key, I can press on the icon, detach > > from the Dock/Clip but when I move the icon near the Dock/Clip, the > > icon cannot be attached and the shadow is not painted. Try this: - startx windowmaker - run wmclock (or other docked app) - Move it to the Clip (with or without Alt) And then: - Push and hold Alt key - Click on the docked app - Detach it from the Clip (continue holding the Alt key and the mouse button) Now, if you try to attach it again, you can't! You must release the Alt key and then push it again to attach the icon again (don't release the mouse button). With the old behavior, when you hold the Alt key and detach the icon, then, the shadow is painted and the icon is ready to be attached to the Clip or the Dock. Now, the icon cannot be attached without release and push again the Alt key nor the shadow is painted. > Let me try to get this straight. Start situation: a running appicon, > either the appicon of a regular application or an wm applet. That Yes. > appicon is docked (on the dock, clip or drawer). The action: you press > alt, then click the appicon, hold the click and start dragging. As the Hold the click and hold the Alt key. Probably this is the difference. I hold the Alt key always: - Press Alt key - Click on the appicon - Move the icon - Attach to other dock/clip/drawer - Release the Alt key. > appicon moves, there is no "shadow" (rather, a "ghost" tile?) behind Yes, and no. If you move the icon without Alt, the shadow is painted. If you press the Alt key, the shadow is not painted. the behavior should be the same. > it, indicating that the appicon will be undocked when the click is > released. Even if the appicon is moved somewhere else in the dock or to > the clip, still no ghost tile, no docking possible. If you release Alt, No. If you move the icon, without the Alt key press (click on border), the shadow is painted. If you hold the Alt key, the shadow is not painted. Is painted when the user release the Alt key. > docking is possible. If however the docked appicon was marked as "Lock > (prevent accidental removal)", it cannot be undocked, even with alt > pressed. > > I believe the above paragraph is true with the old and new code. If you Noooop :-) > still observe a difference between the old and new behaviors, please > describe it in great details like I tried to do above. Done > -- Daniel Thanks a lot Daniel, kix > ----- Mail original ----- > > Hi Daniel, > > > > the behavior is not the same than before. If we have the clip and the > > dock, and I move the icon without Alt key, using the icon border, I > > can move the icon from the clip to the dock, with the shadow,... But, > > If I move the icon using the Alt key, I can press on the icon, detach > > from the Dock/Clip but when I move the icon near the Dock/Clip, the > > icon cannot be attached and the shadow is not painted. I need to > > release the Alt key, and push it again. > > > > Is possible to do it without release the alt key? > > > > Thanks > > kix. > > > > > > [email protected] escribió: > > > > > From: Daniel Déchelotte <[email protected]> > > > > > > The first patch fixes the bug recently discussed in the thread > > > "IMPORTANT BUG: Unable to attach > > > dockapps to Clip/Dock". Then 3 fixes, one for a crashing bug. Then > > > a > > > minor improvement when removing > > > a drawer with a single appicon, and removing some dead code. > > > > > > Daniel Déchelotte (6): > > > When moving an undocked appicon (or applet), allow it to be > > > docked > > > even if Alt is still pressed > > > BF: prevents crash when toggling auto-attract on a drawer with > > > clip > > > disabled > > > BF: correctly initialize the drawer tile when the dock is on the > > > left > > > side > > > BF for stacking level bug when creating a drawer in a keep-on-top > > > dock > > > When removing a drawer containing a single appicon, the latter is > > > docked where the drawer was, instead of being totally undocked. > > > Remove dead code for a confirmation dialog that we'll probably > > > never > > > want to show > > > > > > src/appicon.c | 2 +- > > > src/dock.c | 68 > > > +++++++++++++++++++++++++-------------------------------- > > > src/screen.c | 11 +++++++++- > > > 3 files changed, 41 insertions(+), 40 deletions(-) > > > > > > -- > > > 1.7.10.4 > > > > > > > > > -- > > > To unsubscribe, send mail to > > > [email protected]. > > > > > > Rodolfo García Peñas (kix) > > http://www.kix.es/ > > > > > -- > To unsubscribe, send mail to [email protected]. -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
