----- Carlos R. Mafra <crma...@gmail.com> a écrit : > On Fri, 1 Nov 2013 at 16:06:44 +0100, Christophe wrote: > > From: Christophe CURIS <christophe.cu...@free.fr> > > > > Hello, > > > > This series of patch is the last big work on the cleanup for unused > > args in functions: > > I get a lot of warnings still: > > [...] > > So I hope this series is not really the last...
The "good" point is that I seem the have the same on my side. Now for the why I have not yet fixed them: - WINGs: 8 warnings These are related to piece of codes that seems to not have been written yet! I would feel really sad to remove this code as 'dead code'; I don't feel quite ok to hide the warnings as it's a place to work... (I do hope to find some time to take care of this someday) - wmaker: 3 warnings The 2 in dock.c have 2 possible "clean" solution: * functional programming: we just remove the args; * object programming: these args are the object being worked on (the dock) so it would not be clean to remove them, just tell the compiler it is ok. I have a pending patch for solution 2, but I'd prefer your feedback on this choice; The 3rd in "event.c" is a bad case also: as the comment show, this part of code needs a little work, so "fixing" the warning feels kie hiding the stuff under the carpet... - WPrefs: 5 warnings Two of them are similar case to dock.c, with similar pending patch depending again on your feeling about the coding style; The remaining 3 are special: it's a function whose content have been disabled with what looks like a temporary solution - I feel we should keep the warning until someone fixes properly the code at that place; - test: 11 warnings I did not even dare look at them, my current feeling is that this piece of code should be drown in the lake (discretely, we're not proud of it), it tests things no more used (as I saw the last time I looked at it) -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
