----- Rodolfo García Peñas (kix) <[email protected]> a écrit :
> This patch removes the unused code in the function makeTitledIcon().
> 
> The arguments are not used, so are removed to avoid compiler warnings.
> ---
>  WPrefs.app/WPrefs.c | 66 
> ++---------------------------------------------------
>  1 file changed, 2 insertions(+), 64 deletions(-)
> 
> diff --git a/WPrefs.app/WPrefs.c b/WPrefs.app/WPrefs.c
> index 7afa42e..138030f 100644
> --- a/WPrefs.app/WPrefs.c
> +++ b/WPrefs.app/WPrefs.c
> @@ -443,71 +443,9 @@ void CreateImages(WMScreen *scr, RContext *rc, RImage 
> *xis, const char *file,
>  }
>  
>  
> -static WMPixmap *makeTitledIcon(WMScreen * scr, WMPixmap * icon, const char 
> *title1, const char *title2)
> +static WMPixmap *makeTitledIcon(WMPixmap *icon)
>  {
>       return WMRetainPixmap(icon);
> -
> -#if 0
> [...]

Hi,
I find it a bit sad to stop there, I'm sure it would be possible to make a step 
further and completely get rid of the function, simplifying the code below...


> -#endif
>  }
>  
>  void SetButtonAlphaImage(WMScreen * scr, WMButton * bPtr, const char *file, 
> const char *title1, const char *title2)
> @@ -532,7 +470,7 @@ void SetButtonAlphaImage(WMScreen * scr, WMButton * bPtr, 
> const char *file, cons
>       }
>  
>       if (icon) {
> -             icon2 = makeTitledIcon(scr, icon, title1, title2);
> +             icon2 = makeTitledIcon(icon);
>               if (icon)
>                       WMReleasePixmap(icon);
>       } else {
> -- 
> 1.8.5.2
> 
> 
> -- 
> To unsubscribe, send mail to [email protected].


--
To unsubscribe, send mail to [email protected].

Reply via email to