On Sun,  9 Feb 2014 at 23:14:31 +0100, Christophe wrote:
> 
> ----- Rodolfo García Peñas (kix) <[email protected]> a écrit :
> > This patch initialize the variable "state" to avoid compiler warnings.
> > ---
> >  WPrefs.app/Expert.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> 
> Hi,
> Actually, this warning was already fixed by
> http://repo.or.cz/w/wmaker-crm.git/commit/0d66173e1ff70c2bc0c96fae12f5c438dba9af44
> 
> I would personally suggest to not keep the change below because it can
> potentially hide corner cases that the compiler would detect otherwise.

Thanks Christophe! I removed the patch and rebased the #next branch.


> 
> > diff --git a/WPrefs.app/Expert.c b/WPrefs.app/Expert.c
> > index e939df0..c441612 100644
> > --- a/WPrefs.app/Expert.c
> > +++ b/WPrefs.app/Expert.c
> > @@ -102,7 +102,7 @@ static void createPanel(Panel * p)
> >     WMScrollView *sv;
> >     WMFrame *f;
> >     WMUserDefaults *udb;
> > -   int i, state;
> > +   int i, state = 0;
> >  
> >     panel->box = WMCreateBox(panel->parent);
> >     WMSetViewExpandsToParent(WMWidgetView(panel->box), 2, 2, 2, 2);
> > -- 
> > 1.8.5.2
> > 
> > 
> > -- 
> > To unsubscribe, send mail to [email protected].
> 
> 
> --
> To unsubscribe, send mail to [email protected].


-- 
To unsubscribe, send mail to [email protected].

Reply via email to