>I think it's better to use the lower case prefix. There's no need >to scream...
yes you can change this, but at least we should rename "fatal error" to "fatal" The original log will be the same. for syslog it's the code below: + options = LOG_PID; + openlog(prog_name, options, LOG_DAEMON); so syslog log will contain "wmaker[pid]:" followed by the msg from the original log regards, david On Thu, Feb 13, 2014 at 8:19 PM, Carlos R. Mafra <[email protected]> wrote: > On Thu, 13 Feb 2014 at 19:04:41 +0800, David Maciejak wrote: >> This patch is used to add support for syslog messaging implemented in >> WINGs lib directly, so available from the lib itself and wmaker too. >> I believe it will in a first time help to get some logging info >> centralized in one point, and in a second time maybe add some info >> level messages like wmaker is starting, stopping, restarting and else. >> For now, it's built by default when the syslog support is found, maybe >> we could also disable it by default. > > The idea is very nice and welcome, thanks a lot for doing this! > >> switch (type) { >> case WMESSAGE_TYPE_FATAL: >> - strncat(buf, _("fatal error: "), linemax - 1 - strlen(buf)); >> + strncat(buf, _("FATAL: "), linemax - 1 - strlen(buf)); > > I think it's better to use the lower case prefix. There's no need > to scream... > > I assume there will be an overall "wmaker" prefix too in the log, > is that the case? > > > -- > To unsubscribe, send mail to [email protected]. -- To unsubscribe, send mail to [email protected].
