----- Carlos R. Mafra <[email protected]> a écrit : > On Sat, 1 Mar 2014 at 19:13:43 +0100, Christophe wrote: > > > > > > > > This serie of patchs is implementing the changes that I have proposed > > > to David's patch: > > > > > > - patch 1 / for review: contains the changes against the patch, for > > > easier review; > > For some reason this patch did not arrive at the mailing list together with > the others.
That's probably because I messed up the title, it arrived as: [PATCH] WUtil: Renamed 'syslog_shutdown' to have an API consistent name instead of [PATCH 1/3 for review] WUtil: Renamed... > > > - patch 1 / merged: proposes the same changes merged into the original > > > patch, to replace the commit 320430efe5642db07c82d75a6e6311065233d622 to > > > keep a simpler history (again, will be handy at changelog writing time); > > > > > > Commit id was meant to be: 4a17aa58626ba27d56fe5a5cbdff3b415c2464b3 > > This is very kind of you, to propose your fixes to be merged into his > patch. > > I was hoping that David would address your review comments in a new > version of his patch, but now we don't need to wait any longer :-) >From a little discussion with him, he seems to be more in favor of a >patch-over-a-patch (or maybe he's not yet an expert of git's amend/rebase >stuff) > > > - patch 2: fixes a small thing seen while making the patch > > > > > > - patch 3: more fixes I missed during first review. Could be amended to > > > patch 1 without regret > > Thanks a lot Christophe! I'm sure all wmaker users appreciate your > contributions. Thanks, I hope so! -- To unsubscribe, send mail to [email protected].
