----- BALATON Zoltan <[email protected]> a écrit : > On Sat, 7 Jun 2014, Christophe wrote: > > From: Christophe CURIS <[email protected]> > > > > [...] > > > > diff --git a/wmix/Makefile b/wmix/Makefile > > @@ -5,8 +5,7 @@ LIBS = -lXpm -lXext -lX11 -lm > > > > # where to install this program (also for packaging stuff) > > -DESTDIR = > > -PREFIX = $(DESTDIR)/usr/X11R6 > > DESTDIR is usually there so that distributions can install stuff in a > build root during packaging like this: > > build with PREFIX=/usr/X11R6 > make install DESTDIR=/tmp/build-root > > Does your change break this or is there another way to do the same? (If > PREFIX is not compiled in the program but only used for installing stuff > it may be OK.)
Hi, Yes, the patch breaks this, because I did not see this usage (due to the poor implementation). The good news is that PREFIX not being used anywhere in the code at the moment, you can still do this: make PREFIX=/whatever make install PREFIX=/some-tmp-build-root/whatever The problem is that the old implementation feels broken by design, it is too prone to user errors the way it was coded: - PREFIX is not supposed to be changed with DESTDIR (if you set DESTDIR during compile time, you'll have surprises); - name of variables are counter intuitive (DESTDIR suggests the place where the program will be installed, and PREFIX suggest a prefix added (temporarily) to it - quite the opposite of what it did; - it assumes that the makefile only copies files during 'make install' (so that PREFIX can be changed compared to the compilation value), which from experience cannot be guaranteed (ranging from developer errors to make behaviour) So if you want the feature back, do not hesitate to ask (I totally agree to make packagers' life easier), but note that it will not be implemented in the exact same way. -- To unsubscribe, send mail to [email protected].
