Hi David, really, nice patch. Probably we should include this change some time ago. I remember this problem. Perhaps you can read this [1] thread about it, there are more ideas like use other atoms, but with your change mostly applications set the icon title.
[1] (Help with Atom (window/icon titles)) http://lists.windowmaker.org/dev/thrd42.html#04163 Cheers, kix David Maciejak <[email protected]> escribió:
As reported by Charles some days ago, some apps like okular or vlc are not setting an icon name. This patch is setting the icon name to the window name when _NET_WM_ICON_NAME is not provided by the app. --- src/icon.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/icon.c b/src/icon.c index 1aa27ea..e1321fa 100644 --- a/src/icon.c +++ b/src/icon.c @@ -328,10 +328,12 @@ void wIconChangeTitle(WIcon *icon, WWindow *wwin) if (icon->icon_name != NULL) XFree(icon->icon_name); - /* Set the new one, using two methods */ + /* Set the new one, using two methods to identify + the icon name or switch back to window name */ icon->icon_name = wNETWMGetIconName(wwin->client_win); if (!icon->icon_name) - wGetIconName(dpy, wwin->client_win, &icon->icon_name); + if (!wGetIconName(dpy, wwin->client_win, &icon->icon_name)) + icon->icon_name = wNETWMGetWindowName(wwin->client_win); } RImage *wIconValidateIconSize(RImage *icon, int max_size) --
Rodolfo García Peñas (kix) http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
