From: Christophe CURIS <christophe.cu...@free.fr>
As pointed by Coverity, if dock is still null at this point then the
function will return via the previous check, because it is not possible to
have icon_pos >= 0 if dock is null.
This patch removes the check because it complicate the code which is not
recommended for maintainability.
Signed-off-by: Christophe CURIS <christophe.cu...@free.fr>
---
src/xdnd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/xdnd.c b/src/xdnd.c
index 2a73c4b..afbbd44 100644
--- a/src/xdnd.c
+++ b/src/xdnd.c
@@ -226,8 +226,7 @@ static Bool acceptXDND(Window window)
}
if (icon_pos < 0)
return False;
- if (!dock)
- return False;
+
if (isAwareXDND(dock->icon_array[icon_pos]->icon->icon_win))
return False;
--
2.1.1
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
