On Mon, 22 Dec 2014 at 15:20:26 +0000, Rodolfo García Peñas (kix) wrote:
> Hi,
>
> I found these lines:
>
> 1543 #ifdef GLOBAL_SUBMENU_FILE
> 1544 if (includeGlobals) {
> 1545 WMenu *submenu;
> 1546 WMenuEntry *mentry;
> 1547
> 1548 submenu = readMenuFile(scr, GLOBAL_SUBMENU_FILE);
> 1549
> 1550 if (submenu) {
> 1551 mentry = wMenuAddCallback(menu, submenu->frame->title, NULL, NULL);
> 1552 wMenuEntrySetCascade(menu, mentry, submenu);
> 1553 }
> 1554 }
> 1555 #else
> 1556 /* Parameter not used, but tell the compiler that it is ok */
> 1557 (void) includeGlobals;
> 1558 #endif
>
> The variable "GLOBAL_SUBMENU_FILE" is never defined (I did a rgrep).
> IMO, we should remove lines 1543-1558 and remove the variable
> "includeGlobals" as argument in the function configureMenu.
>
> What do you think?
Please send a patch, your observation seems correct.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
