Hi devs,

Thanks for the quick commit! I see something strange happening though, after the code changes below: these four translations don't show up anymore. The msgid's and msgstr's themselves weren't changed, and the same .mo file works in last stable release.


Christophe CURIS schreef:
diff --git a/WPrefs.app/Icons.c b/WPrefs.app/Icons.c
index 5ebd586..764405f 100644
--- a/WPrefs.app/Icons.c
+++ b/WPrefs.app/Icons.c
@@ -21,6 +21,17 @@
#include "WPrefs.h" +
+static const struct {
+       const char *db_value;
+       const char *label;
+} icon_animation[] = {
+       { "zoom",  N_("Shrinking/Zooming") },
+       { "twist", N_("Spinning/Twisting") },
+       { "flip",  N_("3D-flipping") },
+       { "none",  N_("None") }
+};
+


I don't know if it's related - I'm no coder, so never trust any C patches from me ;-) - but I get this unusual error when running `make' manually to create the .pot file for WPrefs. Note that the//non-ascii cédille is in the same WPrefs.app/Icons.c, but that could be coincidence.

alwin@guri ~/tmp/wmaker-crm-943ae7fdea89cfced3bc99ebec12bc673ca93a6c.tar/wmaker-crm-943ae7fdea89cfced3bc99ebec12bc673ca93a6c/wmaker-crm/WPrefs.app/po $ make WPrefs.pot
xgettext --default-domain=WPrefs \
--add-comments --keyword=_ --keyword=N_ ../../WPrefs.app/Appearance.c ../../WPrefs.app/Configurations.c ../../WPrefs.app/Docks.c ../../WPrefs.app/Expert.c ../../WPrefs.app/Focus.c ../../WPrefs.app/FontSimple.c ../../WPrefs.app/Icons.c ../../WPrefs.app/KeyboardSettings.c ../../WPrefs.app/KeyboardShortcuts.c ../../WPrefs.app/Menu.c ../../WPrefs.app/MenuPreferences.c ../../WPrefs.app/MouseSettings.c ../../WPrefs.app/Paths.c ../../WPrefs.app/Preferences.c ../../WPrefs.app/TexturePanel.c ../../WPrefs.app/Themes.c ../../WPrefs.app/WPrefs.c ../../WPrefs.app/WindowHandling.c ../../WPrefs.app/Workspace.c ../../WPrefs.app/main.c
xgettext: Non-ASCII string at ../../WPrefs.app/Icons.c:346.
          Please specify the source encoding through --from-code.
Makefile:515: recipe for target 'WPrefs.pot' failed
make: *** [WPrefs.pot] Error 1

Adding `--from-code=UTF-8' solves it. Strangely I don't get this error in the build log, when installing WindowMaker through the build system. I'm using a modified live ebuild for git from Gentoo's GNUstep overlay, but this only configures the desired languages, and leaves the rest to WindowMaker:

Making all in po
make[3]: Entering directory '/var/temp/portage/x11-wm/windowmaker-9999/work/windowmaker-9999/WPrefs.app/po'
msgfmt -c -o nl.mo nl.po
make[3]: Leaving directory '/var/temp/portage/x11-wm/windowmaker-9999/work/windowmaker-9999/WPrefs.app/po'

A nice brain braker for the dev list.


Cheers!

--
[alwin]



--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

Reply via email to