On Tue, 19 Apr 2016 at 21:26:45 +0300, Alexandru Lazar wrote: > >>getstyle should either fix this automatically (by renaming one of the > >>files after the relocation) or complain about it. > > > >I think it should not "fix" this automatically. Suppose > >you rename it. Are you going to rename it to what? We should > >avoid surprises. > > There's a finite number of assets that can define a theme, so > renaming file.png to file_1.png (and subsequently file_2.png, up to > file_<nresources>.png) would be harmless. > > I may not have been completely clear here -- I'm not thinking of > renaming the original files (which would be an unpleasant surprise) > just of copying them under a different name under > <themedir>/assets/. E.g. /home/user/tiles/blue.png would be copied > as <themedir>/assets/blue.png; the next file called blue.png that > getstyle encounters would be copied as <themedir>/assets/blue_1.png. > > We could complain about it have the user fix this, but I bet 90% of > the users would go ahead and rename file.png to file_1.png, too. > > I'm not married to this idea though (especially since it requires > more code and, therefore, more bugs). The case is unlikely enough > that we could just keep this thing in mind as a possible > improvement, and do it later if someone asks.
Since this scenario is very unlikely I'd say we must keep the code as simple as possible. A warning is enough. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
