The two changes sound good. As for refactoring DOM/OMUtils with ElementSource, I guess we could simply get rid of the element specific methods which are now implemented with ElementSource.
Just to let you all know, since I'm attending GHC2006 in San Diego + travelling a bit, I would not be able to contribute much to woden-44 during this week.
Thanks,
Oshani
On 10/3/06, John Kaputin <[EMAIL PROTECTED]> wrote:
Oshani,
Now that wsdl4j and Woden releases are done, I have been looking at
WODEN-44 again. Hoping to finish before today's telecon/chat.
So far I have made these changes in the WODEN-44 branch:
1. changed getAllElementAttributes back to getAttributes, as agreed 9/12
2. changed reader.createElementSource(Object) from a public API method to a
protected impl method as it is currently only used internally and we don't
yet have a need for it on the API (we can revert back if there is a need
for it, but maybe a noarg method similar to reader.createWSDLSource() would
be better for consistency)
I am about to review the DOMUtils methods used by the reader to consider
refactoring them into ElementSource, as you suggested.
regards,
John Kaputin
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
