Hi guys, Just a simple interruption. When code contributions (such as this one) happen it is always recommended to go through the Jira. When you have a code contribution add it to a Jira issue (if none exists create one) and if it is intended to be checked in, there is a field that allows one to agree to the legalities of ASF. So if you go through the Jira, ASF is always off the hook.
The right way to go about this is to attach the files to a Jira. The ICLA AFAIK is for committers and is not required when a non-committer does a code contribution. Ajith On 8/17/07, Sagara Gunathunga <[EMAIL PROTECTED]> wrote: > > > Hi John, > > As you said I have fixed the problems with patch files and modified codes > according to JIRA (WODEN-177). Also I have removed the > woden.internal.DOMUtils class. But I didn't touch rest of the code because > still I'm having basic questions to solve. Here I have listed below. > > > > (1) > > > > > As a beginning I have studied how serialization is implemented in > > > > > WSDL4J and Apache AXIOM projects. If I summarized what I realized is > > > > > > > > > > > > > > > (1) In WSDL4J? WSDLWriterImpl use basic Java java.io.PrintWriter > > > > > to actual writing tasks and DOMUtils, DOM2Writer used to traversing > > > > and formatting tasks. > > > > > > > > > > (2) In AXIOM - javax.xml.stream.XMLStreamWriter is > used to writing > > > > task. > > > > > > > > > > > > > > > Then I came up with 2 ideas for Woden serialization implementation > > > > > > > > > > (1) Use an approach that similar to WSDL4J, means > > > > > java.io.PrintWriter for writing task and use of DOMUtils, DOM2Writer > > > > > and OMUtil, OM2Writer for other works. (In this case necessity of two > > > > > Writer implementation is a question?) > > > > > > > > > > > > > > > (2) Use one writer (may be java.io.PrintWriter or any other > > > > > available writer on DOM) for DOMWriterImplemanatation and use > > > > > javax.xml.stream.XMLStreamWriter for > OMWrterImplematation. > > > > > > (2) parseXXX () methods of WSDLWriter take XMLElement as a parameter. In my > case I use Woden Elements as parameters for printXXX() methods. I'm > interesting to have some comments on this issue also. I think this issue is > relevant to the point you mentioned in your last mail. > > > > > Note that DOM elements (and OMElement) > > > are represented in Woden by XMLElement and many of the element access > > > method available via DOMUtils are now available via the XMLElement > > > interface. We might need to think about how to access and use XMLElement > > > objects to serialize the WSDL. > > > It is much easy to me go forward, If you can provide a descriptive comments > for above issues . > thanks > sagara > Blog - ssagara.blogspot.com > > > > > > On 8/15/07, John Kaputin <[EMAIL PROTECTED]> wrote: > > Hi Sagara, > > thanks for your code contribution. I've noticed a few problems with the > > patch files, highlighted below, so have not yet applied the patches to the > > code base. Could you please check all the patch files and fix as required, > > then let me know when you're done and I'll try again. > > > > BaseWSDLWriter.java: > > Contains some WSDL4J references (javax.wsdl.Definition ). > > The patch is duplicated in the patch file. > > It looks like there's some code formatting problems. Can you replace any > > tab characters with spaces and set your code editor settings to use 4 > > spaces for code indentation, not tab characters. > > As per WODEN-179 (opened today) I think we should not pass the > > ErrorHandler as an arg to the writeWSDL methods. Instead, the client can > > use getErrorReporter().setErrorHandler(..) method before > calling > > writeWSDL(desc). > > I've just introduced a WSDLContext object via WODEN-177 for shared access > > to ErrorReporter and ExtensionRegistry objects in Woden. You could > > incorporate that change into your code too - use the wsdl reader > > interfaces/classes for examples. > > > > > > DOMUtils.java: > > This code is also duplicated in the patch file. The DOMUtils class already > > exists in the org.apache.woden.internal.util package. You should add any > > new methods there, rather than add this class to the > > org.apache.woden.internal package. Note that DOM elements (and OMElement) > > are represented in Woden by XMLElement and many of the element access > > method available via DOMUtils are now available via the XMLElement > > interface. We might need to think about how to access and use XMLElement > > objects to serialize the WSDL. It looks like there might also be some code > > formatting problems in this patch file too. > > > > DOMWSDLFactory.java : > > This patch includes unnecessary changes to the comments / boilerplate > > text. I think it should just contain the changes required for the > > newWSDLWriter() method. Note also, the WSDLContext stuff now required, as > > mentioned previously. Ensure you are working from the very latest code, > > as I only committed the WSDLContext stuff earlier today. > > > > WSDLWriter.java: > > Same problem with duplicated code in the patch file. > > I note that this interface does not contain any writeWSDL methods with an > > ErrorHandler arg, yet your BaseWSDLWriter code contains a signature with > > ErrorHandler - > > + * @see > > > org.apache.woden.WSDLWriter#writeWSDL(javax.wsdl.Definition, > > java.io.OutputStream, org.apache.woden.ErrorHandler ) > > Anyway, as per my earlier comment (WODEN-179) we don't need this > > signature, so the WSDLWriter interface is correct - you can remove this > > method signature from BaseWSDLWriter. > > > > > > thanks, > > John Kaputin > > > > "Sagara Gunathunga" <[EMAIL PROTECTED]> wrote on 13/08/2007 > > 15:42:30: > > > > > Hi John, > > > I have already sent my ICLA form to the ASF through the facsimile; > > > please update me whether you receive the document correctly or not. > > > Also within next few days I will update patch files based on our work. > > > When you send your feed back about our work, please provide some > > > guidelines for the questions that I mentioned in my previous mails. > > > > > > Thanks > > > Sagara > > > Blog - ssagara.blogspot.com > > > > > On 8/8/07, John Kaputin < [EMAIL PROTECTED]> wrote: > > > Hi Sagara, > > > here is an excerpt on the ICLA from the link at [6] in Lawrence's email: > > > > > > <start> > > > The ASF desires that all contributors of ideas, code, or documentation > > to > > > the Apache projects complete, sign, and submit (via snailmail or fax) an > > > Individual Contributor License Agreement (CLA) [PDF form]. The purpose > > of > > > this agreement is to clearly define the terms under which intellectual > > > property has been contributed to the ASF and thereby allow us to defend > > > the project should there be a legal dispute regarding the software at > > some > > > future time. A signed CLA is required to be on file before an individual > > > is given commit rights to an ASF project. > > > <end> > > > > > > It's quickest to fax the signed form to Apache if you can, but you can > > > post it if you prefer. We would like to confirm that your signed ICLAs > > > have been received by the Apache Software Foundation before we accept > > any > > > contributions from you and Ashika Umanga. Do you have any further > > concerns > > > about the ICLA? > > > > > > As Lawrence says, you can contribute code by attaching patch files to > > the > > > appropriate JIRA (WODEN-65 for Serialization). When you do so, you tick > > a > > > check box that says "Grant license to ASF for inclusion in ASF works". > > It > > > only makes sense to do this if you've signed the ICLA to agree the terms > > > under which such contributions are made. It is part of the chain of > > > intellectual property protection required so that the ASF can safely > > > distribute it's products under the Apache License so that other > > > products/projects/companies can include this Apache software in their > > > releases. > > > > > > I will send you my feedback on the code files you sent to the list, but > > as > > > requested by Lawrence it would then be best if you could redo this > > > contribution as patch files, based on the latest Woden SVN trunk, > > attached > > > to JIRA WODEN-65. We will wait until your signed ICLA has been > > received > > > by the ASF before committing any code to the repository. > > > > > > thanks, > > > John Kaputin > > > > > > "Sagara Gunathunga" <[EMAIL PROTECTED]> wrote on 08/08/2007 > > > 09:17:21: > > > > > > > Hi Lawrence, > > > > First, thank you for your encouragement. Those comments are very > > > > significant to us to clear lot of doubts about the process. > > > > > > > > I already have created a JIRA account. But in last time I decided > > > > not to upload on JIRA because, those set of classes are just a > > > > preview of works that I hope to do, not complete works. I sent it to > > > > the list to get your feedbacks. > > > > > > > > I happy to sign with ICLA but have some doubts regarding signing it > > > > .Do I have to take a hardcopy and send it throw the post Or do I > > > > have to scan and send it using e-mail or by Fax. > > > > > > > > Also I would be much obliged if you could explain how to work with > > > > test cases and W3C WSDL 2.0 test suite (I tried to download some Zip > > > > files [1], but couldn't download them). I mean how to use above > > > > test cases and test suite with my works (Not about JUnit specific > > stuff) > > > > > > > > > > > > [1] > http://dev.w3.org/cvsweb/2002/ws/desc/test-suite/zips/ > > > > > > > > Thanks, > > > > Sagara > > > > Blog - ssagara.blogspot.com > > > > > > > > > > > > > > On 8/7/07, Lawrence Mandel <[EMAIL PROTECTED]> wrote: > > > > Hi Sagara, > > > > > > > > Good to hear from you and good to hear that you're making progress. > > > > Serialization is a feature that has been requested for some time and I > > > > welcome this type of contribution to Woden. > > > > > > > > A few process details I'd like to share. > > > > > > > > 1. As Woden is an Open Source project there is a certain level of > > > > transparency that we need to maintain. We will all benefit from > > frequent > > > > updates as you progress by posting to the woden-dev list. I'd also > > > > encourage you to participate in our weekly status calls [1]. At the > > very > > > > least this will prevent someone else (such as Dan) from duplicating > > your > > > > work. > > > > > > > > 2. In order for Woden to accept code contributions the code needs to > > be > > > > attached to a Jira [2] entry. You can sign up for a free account. We > > > also > > > > typically like to receive patches instead of source files. Patches > > allow > > > > reviewers to quickly see the changes you've made. Can you please sync > > > your > > > > code with Woden's HEAD stream and create a patch. (If you're > > unfamiliar > > > > with creating patches take a look at [3] or feel free to drop me a > > line > > > > and I'll walk you through it. It's pretty straightforward using a > > client > > > > > > > such as Eclipse.) > > > > > > > > 3. Apache requests that all contributors sign an Individual > > Contributor > > > > License Agreement (ICLA) [4]. The ICLA is for the protection of Apache > > > and > > > > your code. Please let me know if you have any issue with this > > agreement. > > > > > > > If not, please sign and return a completed ICLA form to the Apache > > > > Software Foundation. > > > > > > > > You might also be interested in the resources found at [5], especially > > > > [6]. > > > > > > > > Again, welcome to the Woden developer community. I look forward to > > > > reviewing your serialization contribution. > > > > > > > > [1] > > > http://incubator.apache.org/woden/dev/index.html#Weekly+Status+Call > > > > [2] http://issues.apache.org/jira/browse/Woden > > > > [3] http://apache.org/dev/contributors.html#patches > > > > [4] http://apache.org/licenses/#clas > > > > [5] http://apache.org/dev/ > > > > [6] http://apache.org/dev/contributors.html > > > > > > > > Lawrence > > > > > > > > > > > > > > > > > > > > John Kaputin < [EMAIL PROTECTED]> > > > > 08/01/2007 11:01 AM > > > > Please respond to > > > > woden-dev@ws.apache.org > > > > > > > > > > > > To > > > > woden-dev@ws.apache.org > > > > cc > > > > > > > > Subject > > > > Re: Woden serialization > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi Sagara, > > > > We didn't hear from you for a while, so I recently asked Dan Harvey, a > > > > summer intern student, to look at Woden serialization. However, it > > looks > > > > > > > like you've made some good progress so I'll ask him to focus on other > > > > requirements while I look at your code. > > > > > > > > thanks, > > > > John Kaputin > > > > > > > > > > > > "Sagara Gunathunga" < [EMAIL PROTECTED] > wrote on > > 01/08/2007 > > > > 04:18:18: > > > > > > > > > Hi John, > > > > > > > > > > Hope you remember me .after my exams, In from this month I have > > been > > > > > started my works on Woden serialization and I'm sorry, because I > > > > > couldn't update you about the progress of my works on time. > > > > > > > > > > > > > > > As you mentioned I have studied how common behaviors of DOM and > > > > > OM/StAX readers are refactored in to BaseWSDLReader through the > > > > > XMLElement. And I notice that this idea can be reused in Writer > > > > > implementation too. > > > > > > > > > > > > > > > As a beginning I have studied how serialization is implemented in > > > > > WSDL4J and Apache AXIOM projects. If I summarized what I realized is > > > > > > > > > > > > > > > > > (1) In WSDL4J ? WSDLWriterImpl use basic Java java.io.PrintWriter > > to > > > > > actual writing tasks and DOMUtils, DOM2Writer used to traversing and > > > > > formatting tasks. > > > > > > > > > > > > > > > > > > > > (2) In AXIOM - javax.xml.stream.XMLStreamWriter > is used to writing > > > > task. > > > > > > > > > > > > > > > Then I came up with 2 ideas for Woden serialization implementation > > > > > > > > > > > > > > > > > > > > (1) ? use an approach that similar to WSDL4J, means > > > > > java.io.PrintWriter for writing task and use of DOMUtils, DOM2Writer > > > > > and OMUtil,OM2Writer for other works. (In this case necessity of two > > > > > > > Writer implementations is a question?) > > > > > > > > > > > > > > > (2) - Use one writer (may be java.io.PrintWriter or any other > > > > > available writer on DOM) for DOMWriterImplemanatation and use > > > > > javax.xml.stream.XMLStreamWriter for > OMWrterImplematation. Then we > > can > > > > > refrctor common behaviors in to BaseWSDLWriter class. > > > > > > > > > > > > > > > > > > > > As this is my first contribution, give your comments on this issue. > > > > > BTW I have partly implemented WSDLReader interface and DOMWriterImpl > > > > > based on WSDL4J concepts. > > > > > > > > > > With this mail I have attach them, please check them also. > > > > > > > > > > > > > > > > > > > > Further, from last week, one of my friends works with me for Woden > > > > > serialization. His name is Umanga Umagaliya he also loves to works > > > > > with Java and open source. He will be joining to the mailing list > > very > > > > > soon. > > > > > > > > > > > > > > > > > > > > I'm really interesting work on this area and if you allow us, we > > > > > (Umanga and I) can continue the development Woden serialization. > > > > > > > > > > > > > > > > > > > > Regards > > > > > > > > > > Sagara Gunathunga > > > > > > > > > > Blog - ssagara.blogspot.com > > > > > [attachment " BaseWSDLWriter.java" deleted by John Kaputin/UK/IBM] > > > > > [attachment " DOMUtils.java" deleted by John Kaputin/UK/IBM] > > > > > [attachment "DOMWSDLFactory.java" deleted by John Kaputin/UK/IBM] > > > > > [attachment "DOMWSDLWriter.java" deleted by John Kaputin/UK/IBM] > > > > > [attachment "OMWSDLFactory.java" deleted by John Kaputin/UK/IBM] > > > > > [attachment "OMWSDLWriter.java " deleted by John Kaputin/UK/IBM] > > > > > [attachment " WSDLFactory.java" deleted by John Kaputin/UK/IBM] > > > > > [attachment "WSDLWriter.java" deleted by John Kaputin/UK/IBM] > > > > > [attachment " sample1.java" deleted by John Kaputin/UK/IBM] > > > > > [attachment "test.wsdl" deleted by John Kaputin/UK/IBM] > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > Unless stated otherwise above: > > > > IBM United Kingdom Limited - Registered in England and Wales with > > number > > > > 741598. > > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > > > > > 3AU > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > -- > > > > Sagara Gunathunga > > > > > > > > Blog - ssagara.blogspot.com > > > > > > > > > > > > > > > > > > Unless stated otherwise above: > > > IBM United Kingdom Limited - Registered in England and Wales with number > > > > > 741598. > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > > 3AU > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > -- > > > Sagara Gunathunga > > > > > > Blog - ssagara.blogspot.com > > > > > > > > > > > > Unless stated otherwise above: > > IBM United Kingdom Limited - Registered in England and Wales with number > > 741598. > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > -- > > Sagara Gunathunga > > Blog - ssagara.blogspot.com -- Ajith Ranabahu --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
