On 4 Apr 2010, at 00:05, Mark Johnson wrote:
> On Saturday 03 Apr 2010 22:51:02 Scott Wilson wrote:
>> On 3 Apr 2010, at 22:14, Mark Johnson wrote:
>>> On Saturday 03 Apr 2010 21:32:50 Scott Wilson wrote:
>>>> On 3 Apr 2010, at 20:38, Mark Johnson wrote:
>>>>> On Saturday 03 Apr 2010 19:56:17 Scott Wilson wrote:
>>>>>> On 3 Apr 2010, at 16:37, Mark Johnson wrote:
>>>>>> I wonder if it all zips up all the .svn metadata when building the
>>>>>> included widgets..? Hmm, nope it doesn't appear to.
>>>>>>
>>>>>> I wonder what the difference is with the git files?
>>>>>
>>>>> Very strange indeed!
>>>>> The ownership and permissions on the .git and .svn folders appear to be
>>>>> the same...
>>>>> There's no hard coding in the build process to specifically ignore
>>>>> subversion stuff is there?
>>>>
>>>> After a little digging... there is a default excludes set in Ant's Zip
>>>> task:
>>>>
>>>> There are a set of definitions that are excluded by default from all
>>>> directory-based tasks. They are: **/*~
>>>> **/#*#
>>>> **/.#*
>>>> **/%*%
>>>> **/._*
>>>> **/CVS
>>>> **/CVS/**
>>>> **/.cvsignore
>>>> **/SCCS
>>>> **/SCCS/**
>>>> **/vssver.scc
>>>> **/.svn
>>>> **/.svn/**
>>>> **/.DS_Store
>>>> So that would explain it!
>>>
>>> Indeed I would! Can we add something to the build.xml to exclude .git
>>> also? (I'm not familiar with ant configuration so I honestly have no
>>> idea).
>>
>> Yes, I think if we had an exclude attribute to the zip ant task in
>> widgets/build.xml that should do it:
>>
>> <zip destfile="${widget.build.dir}/${widget.shortname}.wgt"
>> basedir="${wookie.widgets.dir}/${widget.shortname}"
>> excludes="**/.git **/.git/**"
>> />
>>
>> Try this and see if it works.
>
> That does the job, thanks! However, as Gav suspected, it does seem to
> override
> the defaults. I created a dummy .cvs folder to see if it was included, and it
> was, so some additional thought is required if we want .git excluded by
> default (should probably exclude .gitignore as well, like the defaults do
> with
> .cvsignore).
Ah, I hadn't thought of that, its not in the Ant doc I read; maybe it could be
fixed with:
<zip destfile="${widget.build.dir}/${widget.shortname}.wgt"
basedir="${wookie.widgets.dir}/${widget.shortname}"
excludes="**/.git **/.git/**"
defaultexcludes="yes"
/>
> Cheers
> Mark
