On 14 Jun 2010, at 11:59, Gav... wrote:

> Ok, so hopefully you've seen my latest commits, adding in license headers
> where I see appropriate and excluding some files which have other license
> headers or don't need one.

I have indeed - very much appreciated!

> I've reduced the issues from 96 to just 31, but as far as doing a release is
> concerned, 0 is the only acceptable answer.
> 
> I'm stuck on some of the widget stuff:
> 
> This lot I've gone through and think are good.
> 
> widgets/butterfly - seems ok now.
> widgets/camera - seems ok now.
> widgets/chat - seems ok now.
> widgets/forum - seems ok now.
> widgets/localetest - seems ok now.
> widgets/sharedraw - seems ok now.
> widgets/vote - seems ok now.
> widgets/widget-template - seems ok now.
> widgets/youdecide - seems ok now.
> 
> All the below I'm stuck as to what to do:
> 
> widgets/natter - Unsure what to do, jquery.js file say " Copyright (c) 2009
> John Resig" - does that include the whole widget, just that file (which
> seems strange as the file is otherwise empty)

Just that file; its not empty, it contains minified JavaScript (scroll to the 
right...) We also reference it in /WebContent/Shared/js/jquery and it has an 
entry in all_licenses.txt

> widgets/notsupported - I've excluded the whole thing for now, might revisit
> that one and add licenses. (?)

That's one is all our work anyway, and config.xml has the ASL.

> widgets/Sudoku - Unsure what to do, jquery.js file say " Copyright (c) 2009
> John Resig" - does that include the whole widget , etc ...

As above

> widgets/test - config.xml says "Copyright (c) 2009, Scott Wilson" , what
> happens with that? The rest could have license headers added I assume ?

I suggest changing it to match the others.

> widgets/todo - json2.js says "Public Domain." - What happens with that? The
> rest could have license headers added ?

Yes, that just applies to the json2.js file.

> widgets/weather - config.xml says "Example license (based on MIT License)
> Copyright (c) 2008 The Foo Bar Corp" - what happens with that? Can we add
> ASF license headers to the rest of the files here or not?

OK, that one is my fault - it should have the ASL.

> widgets/wookiewiki - creole.js says " * Copyright (c) 2009 Ivan Fomichev ,
> Portions Copyright (c) 2007 Chris Purcell" - does that include the whole
> widget , etc ...

That should apply just to the creole.js file.

> 
> Advice appreciated, 
> 
> See: http://ci.apache.org/projects/wookie/rat-output.html for the list.
> 
> thanks
> 
> Gav...
> 
> 
> 
> 

Reply via email to