On 28 Apr 2011, at 18:49, Ross Gardler wrote: > On 28 Apr 2011, at 18:33, [email protected] wrote: > >> Author: scottbw >> Date: Thu Apr 28 17:33:35 2011 >> New Revision: 1097559 >> >> URL: http://svn.apache.org/viewvc?rev=1097559&view=rev >> Log: >> Removed unused method > > -1 > > The proper way to remove such (public or protected) methods is to deprecate > them for a reasonable amount of time first. The method may be unused here and > in your Wookie installs but we don't know if this is the case for everyone.
Normally yes, though I think an exception is allowed in this case as I only committed the class earlier today > > Ross > > >> >> Modified: >> >> incubator/wookie/trunk/parser/java/src/org/apache/wookie/w3c/updates/UpdateUtils.java >> >> Modified: >> incubator/wookie/trunk/parser/java/src/org/apache/wookie/w3c/updates/UpdateUtils.java >> URL: >> http://svn.apache.org/viewvc/incubator/wookie/trunk/parser/java/src/org/apache/wookie/w3c/updates/UpdateUtils.java?rev=1097559&r1=1097558&r2=1097559&view=diff >> ============================================================================== >> --- >> incubator/wookie/trunk/parser/java/src/org/apache/wookie/w3c/updates/UpdateUtils.java >> (original) >> +++ >> incubator/wookie/trunk/parser/java/src/org/apache/wookie/w3c/updates/UpdateUtils.java >> Thu Apr 28 17:33:35 2011 >> @@ -71,21 +71,6 @@ public class UpdateUtils { >> } >> >> /** >> - * Gets an updated widget of a widget >> - * @param factory >> - * @param widget the widget to update >> - * @param onlyUseHttps only get updates using HTTPS, ignore plain HTTP >> updates >> - * @return the latest version of the widget, or null if there is no >> updated version available, or the updated widget isn't valid >> - */ >> - public static W3CWidget getUpdate(W3CWidgetFactory factory, W3CWidget >> widget, boolean onlyUseHttps){ >> - try { >> - return getUpdate(factory, widget.getIdentifier(), >> widget.getUpdate(), widget.getVersion(), onlyUseHttps); >> - } catch (Exception e) { >> - return null; >> - } >> - } >> - >> - /** >> * Gets the latest version of a widget >> * @param factory >> * @param href the location of the widget Update Description Document >> >>
