On 10/17/2011 04:00 PM, Paul Sharples wrote:
On 16/10/2011 15:13, Ate Douma wrote:
Hi Scott,
I looked at the download you provided and I have several comments and
questions, which is why I opened this separate DISCUSS thread to not pollute
the vote thread itself.
First of all, I assume the target for this artifact is the Maven central
repository, right?
FYI: I have updated the snapshot versions for the parser & connector found
here...
https://repository.apache.org/content/groups/snapshots/org/apache/wookie/
No need to review them, just a heads up - Hopefully these are a quite close to
the final release versions for 0.9.1.
Cool!
And if you don't mind, I just did review them :)
Seems pretty close now, except they are missing a NOTICE and DISCLAIMER file
under META-INF/
Other than that I think these now look fine to me!
Ate
Paul
For that purpose, I think we'll then need a 'proper' maven artifact build,
which means includes a maven project pom (dependency resolution, general
project and artifact meta-data), and preferably also a -sources.jar and
-javadoc.jar artifact for IDE support etc.
Maven based builds of course can produce such additional artifacts as a
trivial by-product, given a proper maven pom that is, but as Wookie currently
is using ivy (which I don't know nothing about) I don't know how such things
are done the ivy way.
I also noticed the binary jar has the sources embedded, which is kind of
unusual nowadays (I think). Not really wrong, but unexpected.
The LICENSE and NOTICE files are contained within the root of the jar while
these IMO should be provided under the META-INF/ folder.
I really think, as a minimum, a proper maven pom is required to even be able
to upload to the Maven repository, and such pom should provide proper
dependency resolutions. Can ivy 'generate' such a maven pom automatically?
If not, I really think the java connector module should be (also) build by
maven itself then, which also will make it much easier to 'stage' the artifact
first through repository.apache.org (Nexus) and after release automatically
'publish' it to Maven central. If you need to do this manually I have no idea
how that (nowadays) works.
Ate Douma
As an side-note: I noticed the current wookie (main) download page only
provides the links to the binary distributions. I was kind of surprised by
that, until I found out that the sources download is provided on a separate
page. Not sure how this is viewed by others, but the common (ASF) practice is
to promote the source distributions as the primary artifacts and typically the
sources and optionally also the binary downloads are provided from the main
download page.
On 10/15/2011 02:17 PM, Scott Wilson wrote:
In order to integrate Wookie and Rave we need a published non-snapshot
version of the Java Connector framework.
While we do have the 0.9.1 release coming soon, it would be good to publish
the 0.9.0 version of the connector to the repository given the full 0.9.0
release is already available, just so we can get Wookie-Rave integration into
the next Rave release.
The scope of the release is the following artifact:
http://people.apache.org/~scottbw/wookie-connector/
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove
S
