I'd like to call for a lazy consensus code review on my patch for WOOKIE-345 
[1]. If there are no objections, I'll commit the changes tomorrow.

Summary of changes:

1. Separated out the abstract interfaces for Widgets and their components in 
the parser from any special processing interfaces needed for XML. So 
"IDescription" rather than "IDescriptionEntity". 

2. Used these abstract interfaces from the parser in the Wookie core rather 
than have separate interfaces doing the same job - so removed IFeature, 
IDescription, IName (etc) from org.apache.wookie.beans

3. Simplified the JPA code to use JPA 2.0 joins rather than inverse 
relationships - this was necessary anyway as a consequence of making the above 
changes to interfaces.

The net result is that there are no changes to functionality (all existing 
tests still pass) or to the majority of internal API methods, but we remove 
around 700 lines of redundant code, and get rid of internal naming 
inconsistencies (like identifier vs guid, IContent vs IStartFile, IIcon vs 
IWidgetIcon etc)

[1] https://issues.apache.org/jira/browse/WOOKIE-345

Reply via email to