URL:
<http://gna.org/bugs/?16674>
Summary: member_mvt::SetAngle() - redundant loops?
Project: Wormux
Submitted by: lampak
Submitted on: Friday 09/10/2010 at 19:29
Category: Characters
Severity: 2 - Minor
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: svn (r8439)
Discussion Lock: Any
_______________________________________________________
Details:
I've bumped into this function by accident while browsing the code.
inline void SetAngle(Double angle)
{
while (angle_rad > TWO_PI)
angle_rad -= TWO_PI;
while (angle_rad <= -TWO_PI)
angle_rad += TWO_PI;
angle_rad = angle;
}
First there are loops to make sure the angle_rad is between -TWO_PI and
TWO_PI. OK. And then it replaces its value with angle.
I know nothing about wormux code but shouldn't the last line be the first one
or something?
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?16674>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wormux-gna mailing list
[email protected]
https://mail.gna.org/listinfo/wormux-gna
