Re: [wp-testers] Redirection problem with tags ending in 'p'

Fri, 07 Nov 2008 17:14:06 -0800 

http://trac.wordpress.org/ticket/8098
I was looking down the same line, But my patch wasnt going to work quite right.. It needs to be tied to either the start of the string, or to &, And i'm not quite sure how to achieve that without 2 expressions. 


On Sat, 08 Nov 2008 12:07:09 +1100, Paul Robinson  
<[EMAIL PROTECTED]> wrote:



Well my regex is a little rusty but I think that says replace all  
instances

of p, page_id, cat or tag with nothing on the redirect query. To stop the
problem you could probably just remove the p so it would say:

$redirect['query'] = preg_replace( '#&?(page_id|cat|tag)=?$#',
'',$redirect['query'] );


It should fix it. It's a good idea to file a bug though. Give that a try  
if

your feeling adventurous to see if it fixes it. :D

Paul.

2008/11/8 Trevor Fitzgerald <[EMAIL PROTECTED]>


I found where the problem is occurring:  Line #207 of  
wp-inc/canonical.php


$redirect['query'] = preg_replace( '#&?(p|page_id|cat|tag)=?$#',
'',$redirect['query'] );

I am not entirely sure what else the line accomplishes so I won't try to
change the regex out of fear of breaking something else.

Nevertheless, I will file a bug report and hopefully somebody else can
attach a patch.

On Fri, Nov 7, 2008 at 7:36 PM, DD32 <[EMAIL PROTECTED]> wrote:


> It only affects ?tag=....p, not the permalinks.. Which is odd.. I'll  
see

if
> i can trace it..
>
>
> On Sat, 08 Nov 2008 11:33:50 +1100, Paleo Pat <[EMAIL PROTECTED]>
> wrote:
>
>  Nope. I click on the tag I created  and it went to the URL
>>
>> http://www.politicalbyline.com/tag/thump/
>>
>>
>>
>> -Paleo Pat
>> http://www.politicalbyline.com
>>
>>
>>
>>
>> On Fri, Nov 7, 2008 at 7:23 PM, Steve <[EMAIL PROTECTED]> wrote:
>>

>>  Do you have any tags that END in the letter "P"? That is what seems  
to

be
>>> causing the problems...
>>>
>>> On Fri, Nov 7, 2008 at 5:16 PM, Paleo Pat <[EMAIL PROTECTED]>
>>> wrote:
>>>

>>> > Not happening here... I clicked on my Blogs most used tag  
Politics...

>>> and
>>> > everything works just fine. :)
>>> >
>>> >
>>> >
>>> > -Paleo Pat
>>> > http://www.politicalbyline.com
>>> >
>>> >
>>> >
>>> >
>>> > On Fri, Nov 7, 2008 at 7:12 PM, Steve <[EMAIL PROTECTED]> wrote:
>>> >

>>> > > I have had a chance to test tags ending in every letter, and  
they

all

>>> > > worked. I also tried several tags ending in "p" (tip, tap, top,  
and

>>> > > macedoniap), and I was always redirected to a page for the tag
>>> without
>>> > the

>>> > > "p" on the end. Capitol (capital?) P's seem to behave the same  
way.

>>> > >
>>> > > On Fri, Nov 7, 2008 at 4:57 PM, Steve <[EMAIL PROTECTED]> wrote:
>>> > >
>>> > > > I can confirm this problem using 2.7b2 on ff 3.0.3... what a
>>> strange

>>> > > > strange bug... I will now test every ending letter to see if  
it's

>>> > limited
>>> > > to
>>> > > > "p"
>>> > > >
>>> > > >

>>> > > > On Fri, Nov 7, 2008 at 3:46 PM, Steve <[EMAIL PROTECTED]>  
wrote:

>>> > > >

>>> > > >> Now THAT is a pretty cool bug... I can't help or anything...  
I

>>> just
>>> > > wanted

>>> > > >> to say that that would be the kind of bug I would program in  
on

>>> > purpose
>>> > > just
>>> > > >> to mess with people.
>>> > > >>

>>> > > >> However, since I'm posting, I will dig around in the source  
code

>>> and
>>> > see
>>> > > >> if I can find where that url is built...
>>> > > >>
>>> > > >>
>>> > > >> On Fri, Nov 7, 2008 at 3:12 PM, Trevor Fitzgerald <
>>> [EMAIL PROTECTED]
>>> > > >wrote:
>>> > > >>
>>> > > >>> For any of the tags I add that end in a 'p', I'm getting a
>>> > redirection
>>> > > >>> problem when I try to visit the tag archive page.
>>> > > >>>
>>> > > >>> http://localhost/?tag=tip is redirecting me to
>>> > > http://localhost/?tag=ti
>>> > > >>>

>>> > > >>> Strange behavior considering all the other tags work fine.   
I

>>> have
>>> > > tried
>>> > > >>> to
>>> > > >>> hunt it down but to no avail.
>>> > > >>>
>>> > > >>> Trevor Fitzgerald
>>> > > >>> _______________________________________________
>>> > > >>> wp-testers mailing list
>>> > > >>> [email protected]
>>> > > >>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>> > > >>>
>>> > > >>
>>> > > >>
>>> > > >
>>> > > _______________________________________________
>>> > > wp-testers mailing list
>>> > > [email protected]
>>> > > http://lists.automattic.com/mailman/listinfo/wp-testers
>>> > >
>>> > _______________________________________________
>>> > wp-testers mailing list
>>> > [email protected]
>>> > http://lists.automattic.com/mailman/listinfo/wp-testers
>>> >
>>> _______________________________________________
>>> wp-testers mailing list
>>> [email protected]
>>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>>
>>>  _______________________________________________
>> wp-testers mailing list
>> [email protected]
>> http://lists.automattic.com/mailman/listinfo/wp-testers
>>
>>
>
> _______________________________________________
> wp-testers mailing list
> [email protected]
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
_______________________________________________
wp-testers mailing list
[email protected]
http://lists.automattic.com/mailman/listinfo/wp-testers


_______________________________________________
wp-testers mailing list
[email protected]
http://lists.automattic.com/mailman/listinfo/wp-testers




_______________________________________________
wp-testers mailing list
[email protected]
http://lists.automattic.com/mailman/listinfo/wp-testers























					Reply via email to