Sebastiaan Troost schrieb:
This modification stops wpkg from adding an installed pkg to the local xml.
I now changed it back to the way it was and added to line 1175:
if (!bypass) {
and to line 1184:
}
Tomek, I suggest you add this too ;)
Sorry, but I disagree.
I've been looking through the code to find an explanation for the
behaviour of your wpkg.
Could you please run wpkg wigh /debug turned on and send the output here?
I assume, you do not have any "check" nodes in your packages.xml for the
abovementioned pkg.
If there is no "check" node, a package is ALWAYS considered as not
installed.
Even on earlier wpkg-releases the script should exit on line 1466.
To make this more clear, I suggest the following changes to wpkg.js
(from WPKG 0.9-test4)
1)
insert a debug-output on line 1271
1270 : if (checkNodes.length == 0) {
1271-add : if (debug) {info("checkInstalled failed because there are no
\"check\" nodes defined");}
------------
2)
I suggest changing the line 243:
243-old : if (force && isArgSet(argv, "/synchronize")) {
243-new : if (force) {
so the "/force" switch does work always, even without synchronize.
(otherwise the /help text is misleading.)
3)
to avoid false positives:
add en "else clause" around the "save xml" in installPackage()
1469-old : }
1469-new : } else {
1483-old : }
1483-old : }}
(the linenumbers are from unaltered wpkg.js)
so it should become clear that only an installation which passed
/checkInstalled/ can be saved to wpkg.xml.
all other methods do not have this problem:
upgrade,remove: already have a similar "else"
executeonce: does not even check for a successfull execution!
This week there will be a (huge) patch which unifies the
packageprocessing (installPackage,executeOnce,removePackage and
upgradePackage). After that it should be easier to resolve problems like
this.
best regards
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
wpkg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wpkg-users
