[ http://issues.apache.org/jira/browse/WSIF-68?page=comments#action_12360522 ]
Jeff Greif commented on WSIF-68: -------------------------------- The notation used in this code is slightly confusing. For an <element>, the typeName variable holds the *name* of the element, while the elementType holds the schema type to which it conforms (as determined by the "type" attribute). In between the two segments of this patch, the typeName variable is set to value of the "name" attribute. Thus the patch seems correct as far as it goes. It's possible that if ref="qname" is found, that the elementType should be determined from the global element referred to, but it's not guaranteed that the global element has yet been processed when this code executes. > schema parsing incorrect/incomplete for <element> > ------------------------------------------------- > > Key: WSIF-68 > URL: http://issues.apache.org/jira/browse/WSIF-68 > Project: Axis-WSIF > Type: Bug > Components: Basic Architecture > Versions: current (nightly) > Environment: Windows 2000 SP4, J2SE 1.4.2_05 > Reporter: Jeff Greif > Assignee: Aleksander Slominski > Priority: Minor > > org.apache.wsif.schema.ElementType parsing incorrectly specifies the default > namespace for the "type" attribute of <xsd:element>, and fails to account for > a possible "ref=..." element. > Code diff: > cvs diff: Diffing . > Index: ElementType.java > =================================================================== > RCS file: > /home/cvspublic/ws-wsif/java/src/org/apache/wsif/schema/ElementType.ja > va,v > retrieving revision 1.7 > diff -r1.7 ElementType.java > 56c56,59 > < elementType = getAttributeQName(el, "type", tns); > --- > > // jgreif Webalo, Inc. -- incorrect to use tns as default namespace > > // for type or ref attribute value ! > > // elementType = getAttributeQName(el, "type", tns); > > elementType = getAttributeQName(el, "type"); > 57a61,66 > > > > // jgreif Webalo, Inc. -- ref attr may appear rather than name attr > > if (typeName == null) { > > typeName = getAttributeQName(el, "ref"); > > } > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
