On 27/02/2015 05:22, Michael Black wrote:

Hi Mike,

Here's a patch that adds CTRL1-6 and modifies the help on the shortcuts.

CTRL1-6 sets the Next button and ALT1-6 sets the Now button (so no change there other than correcting the help file).

Bill…does this sound OK to you?

What you propose will change the help description of the Alt+<number> keystrokes to what they actually do i.e. set the current message. Reviewing the behaviour of WSJT shows that the Alt+<number> short cut changes the message immediately in that application so for consistency WSJT-X should do the same.

Adding keyboard short cuts to do the other action i.e. set the next message, is probably a good idea.

This also is consistent with indicating short cuts reached with Alt+key keystrokes by underlining the active keystroke in the widget label. Since the next message radio buttons are un-labeled, the Alt+key short cut lies naturally with the "Now" buttons.

The problem with the change is that it continues to handle simple short cut keystrokes via a special key press event handler, this is not idiomatic Qt implementation and leads to strange "non-standard" UI behaviour.

Laurie…perhaps you can use the Ctrl instead?

Laurie may even wish to offer both options, perhaps with an Alt+click in JTMacros to do the "other" function i.e. Click to set the next message and Alt+Click to change the current message or vice versa as he sees appropriate.

There is another issue this raises in that the WSJT-X Log QSO window should not be popping up until the 73 message actually starts sending. Currently it is erroneously popping up during a receive period when Alt+5 is clicked, this is a defect which I will fix as well.

I have checked in a change to the develop branch that implements the above changes using the "proper" Qt mechanism rather than by a special application key press event handler. This ensures that the behaviour of the short cut keys is always identical to clicking the widgets directly rather than using a different path through the code that could diverge from the direct mouse click action.

For Laurie this change has a bonus in that now the short cuts are defined in the standard Qt idiom, they are now globally active and can now be activated without having to change the application focus or other such hacks.

There are documentation changes required due to this change.

Mike W9MDB

73
Bill
G4WJS.

*From:*[email protected] [mailto:[email protected]]
*Sent:* Thursday, February 26, 2015 6:25 PM
*To:* [email protected]
*Subject:* Re: [HamApps-Beta] oddity with 2.5.12

On 27/02/2015 2:29 AM, Jim McHale [email protected] <mailto:[email protected]> [HamApps-Beta] wrote:

    Laurie,
    If I click a macro its correctly copied to the tx5 area, but it also
    appears to now do a 'log qso'; which means I see the log qso window
    twice, once when I click in macros, and then again a few seconds
    later
    when the transmission occurs. Is the log qso on filling in tx5 via a
    macro a new expected behaviour?
    I'm running win7x64, jt alert 2.5.12, wsjtx 1.4.0-rc3

    If I turn off in wjstx the 'prompt me to log QSO' then I dont see any
    log qso msg unless i manually invoke it...
    -jim NM1W

Jim,

There has been a change to how JTMacros enables the TX5 radio button. The old position based test and activate is no longer suitable now that WSJT-X allows user configuable fonts and sizes. I had to change to using the Alt-5 WSJT-X hotkey to enable the radio button. Unfortunately, this hotkey will display the WSJT-X Log QSO window if you have the "Prompt me to log QSO" setting checked.

You only option is to either disable the WSJT-X "prompt..." setting or leave that setting and check the JTMacros "Don't Activate" setting. If you check the "Don't Activate" setting, you will need to remember to manually enable the Tx5 radio button.

I know this is not ideal, but with the new font changes in WSJT-X and the lack of a proper WSJT-X interface for 3rd party interaction, this change will have to remain (taht is I can't change back to the old operation method).

de Laurie VK3AMA


------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel

Reply via email to