On 31/05/2015 14:53, Michael Black wrote:
Hi Mike,
I'd say the main problem is that it would be a change in the behavior of
JTAlert Macros.
Well, I think what you are proposing would also mean a change in JTAlert
macros behaviour too.
How about making the effect on tab 1 of setting the message text be to
click the radio button too. The send ASAP option would still be
equivalent to clicking the tab 1 TX now button or clicking the tab 2
radio button.
This solution seems to achieve the same behaviour as before and doesn't
expose the tab 1/2 differences even if the behaviour is different
depending on which tab is current.
Attached is a patch that does the above which you can try out.
Previously you got visual confirmation that the macro was inserted and
queued up for transmit with the button enabled.
Now you're saying you would set the message...but not enable the radio
button and JTAlert would have to add a timer to check for Rx while the user
may change their mind and click something else...etc......so at best the
user will think it's not queued and click it themselves...and there will be
a flurry of messages on the JTAlert email list to bring it back to the way
it was. At worse other actions may cause all sorts of havoc in logic.
73
Mike W9MDB
73
Bill
G4WJS.
-----Original Message-----
From: Bill Somerville [mailto:[email protected]]
Sent: Sunday, May 31, 2015 8:45 AM
To: [email protected]
Subject: Re: [wsjt-devel] Free Text UDP message
On 31/05/2015 14:27, Michael Black wrote:
Hi Mike,
Laurie's desire was that a macro request would "queue" up...just like
it used to do -- right now it either just updates the message without
the button or transmits immediate.
True...operator can always do what they want but minimizing clicks is
always a nice thing for what sounds like the common case. Never
neard anybody on the JTAlert email list complain about the radio button
being enabled.
A tri-state would let the other application allow the user to choose
their desired action.
Or...just adding the active tab to the status would allow something
similar....
I understand the desire but I still feel that is is not worth the extra
complexity of exposing the differences between tab 1 & tab 2. What is the
problem with JTAlert queuing the send free text message internally.
The equivalent effect can be demonstrated in message_aggregator by typing
into the free text box but delaying the pressing of return until the WSJT-X
status returns to Rx. Obviously the delay would be done by the server, but
it has all the desired information to do it, i.e. wait until the status
broadcast indicates Rx mode.
73
Mike W9MDB
73
Bill
G4WJS.
-----Original Message-----
From: Bill Somerville [mailto:[email protected]]
Sent: Sunday, May 31, 2015 8:19 AM
To: [email protected]
Subject: Re: [wsjt-devel] Free Text UDP message
On 31/05/2015 14:12, Michael Black wrote:
Hi Mike,
Laurie says thanks for the recent change on the free text message.
But.would still like be able to enable the radio button on tab 1.
My thinking was to try and keep it simple by hiding the differences
between tab 1 & tab 2. It seems to me that setting of the radio button
on tab 1 for the free text message can be easily achieved by waiting
until the next Rx period starts and then sending the send ASAP message.
This is why I talked about visual feedback i.e. the free text message
can be seen to be changed immediately and the server can choose when
to activate it i.e. now or later.
I wonder if the Send flag should be tri-state?
Send=0 -- update text only
Send=1 -- update text and "ready" button -- i.e. Tab 1 -- Tab 2
ignores
Send=2 -- update text and transmit immediate -- so both Tab 1 & Tab 2
would transmit immediate
Also...perhaps an added item to the status to show the active tab
would be nice. So, for example, tab 3 & 4 one could disable macros
for example if they are not appropriate.
73
Mike W9MDB
73
Bill
G4WJS.
diff --git a/mainwindow.cpp b/mainwindow.cpp
index 5f30575..5234558 100644
--- a/mainwindow.cpp
+++ b/mainwindow.cpp
@@ -190,6 +190,8 @@ MainWindow::MainWindow(bool multiple, QSettings * settings,
QSharedMemory *shdme
ui->tx5->setCurrentText (text);
if (send) {
ui->txb5->click ();
+ } else {
+ ui->txrb5->click ();
}
} else if (1 == ui->tabWidget->currentIndex ()) {
ui->freeTextMsg->setCurrentText (text);
------------------------------------------------------------------------------
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel