Hi Bill,
Your second change/fix in r6532 makes sense to me. Amazing that this hasn’t
shown up til now.
Steve k9an
> On Mar 15, 2016, at 6:47 AM, Bill Somerville <[email protected]> wrote:
>
> On 15/03/2016 10:47, Clemens Heese wrote:
>> Old value = (unsigned char *) 0xbeff9050 ""
>> New value = (unsigned char *) 0xbeff9000
>> "\030@\214\071\"\377\225\071!5\241\071Jخ9\346\363\302\071t\222\006:\347\367\234:`\357A:"
>> encode (symbols=0xbef4564d "\220\377\276\b\300\215\266\330\020\002",
>> data=0xbef45682 "", nbytes=0) at /root/src/wsjtx/src/lib/wsprd/fano.c:77
>> 77 *symbols++ = sym & 1;
> Hi Clemens,
>
> ok, I see the issue. The 'encode()' function is overrunning the output buffer
> because it is going around a loop one too many times. I have committed a
> change that should fix this at r6531 r6532 in the WSJT-X development branch.
>
> Steve, please review my change r6531 as I am uncertain why the 'channelbits'
> array in 'get_wspr_channel_symbols' is 162 long but only the first 160
> elements get filled after my change. Should the 'channelbits' array be 176
> elements and my change above reverted so that it is filled by 11 times 8 bits
> times 2 with only the first 162 symbols relevant to the message?
>
> Thinking further about this I think my first change is wrong and have
> committed another that increases the channelbits array to 176 elements. I
> believe r6532 is now correct.
>
> 73
> Bill
> G4WJS.
> ------------------------------------------------------------------------------
> Transform Data into Opportunity.
> Accelerate data analysis in your applications with
> Intel Data Analytics Acceleration Library.
> Click to learn more.
> http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140_______________________________________________
> wsjt-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/wsjt-devel
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
