On 01/01/2018 22:05, Bill Somerville wrote:
Steve, I am unsure about a couple of the changes I have made, particularly the limited slice of the cdat complex array used when applying the Rayleigh fading model on line 275 (necessary to avoid an array bounds violation when using 11025 Hz rate), and whether I should apply clipping to 16-bit full scale after applying the gain offset at line 288. I also don't understand what line 287 is doing as it seems to apply a normalization factor 'fac' that I would expect to be applied on line 288 yet that line used a fixed factor of 100.0 (`rms`). Perhaps you can review my changes and advise?

Hi Steve,

further to the above, I note that my editor has fixed up the lien endings versus file encoding inconsistency in lib/jt65sim.f90, this make viewing my changes tricky as the whole file appears changed in r8388. I believe you are now using git-svn, if so you can review the real changes with a command like:

git show -w `git svn find-rev r8388`

once you have run `git svn rebase` to pick up the change on your wsjtx branch.

73 & HNY
Bill
G4WJS.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel

Reply via email to