Joe, can we use the 1.7.1 dev branch on air? I've been building along the 1.8.1 branch instead because of an earlier note you had out there.
Thanks! Jim S. N2ADV -----Original Message----- From: Joe Taylor [mailto:[email protected]] Sent: Tuesday, January 23, 2018 9:57 AM To: WSJT software development; AJ Fite Subject: Re: [wsjt-devel] WSJT-X issue with Dark QT themes Hi Al, Thanks for the good suggestion to improve usability of WSJT-X with dark themes. I've put your changes into the development branch code. -- 73, Joe, K1JT On 1/23/2018 2:09 AM, AJ Fite wrote: > Hello WSJT-X devs! > > This could be considered a bug so I'm going to post this like a bug report: > > Pertinent System Info: > Program Version: 1.8.0 > OS: Arch Linux (x64) [though this should be universally reproducible] > DE: KDE Plasma > QT Theme: Breeze-Dark > > Reproduction: > Use a dark theme that sets font colors to white, I use the default > Breeze-Dark QT theme > > You can evidently see the behavior pretty clearly in this image: > https://i.imgur.com/NENfJLj.png <https://i.imgur.com/NENfJLj.png> > > It appears that the background for certain text entry box backgrounds > are hard coded to white rather than using the defalt theme text box > background causing light fonts to be almost unreadable. Optimally > they should be using whatever the QT equivalent of inherit background > color is OR if they could be set in a similar way to the other > background colors that would also be perfect. > > I've pinpointed the two most troublesome parts of the code, making the > changes I outline below impoves usability massively on dark themes, I > was working off the WSJT-X 1.8 branch of the SVN: > > displaytext.cpp line 186 changed from: > QColor bg {Qt::white}; > to: > QColor bg {Qt::transparent}; > > mainwindow.cpp line 4508 changed from: > p.setColor(QPalette::Base,Qt::white); > to: > p.setColor(QPalette::Base,Qt::transparent); > > In theory these changes shouldn't effect light themes as their > backgrounds are already white or a light color, they significantly > help dark themes. > > 73 > AJ Fite N7AJF > > > > > ---------------------------------------------------------------------- > -------- Check out the vibrant tech community on one of the world's > most engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > _______________________________________________ > wsjt-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wsjt-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ wsjt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wsjt-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ wsjt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wsjt-devel
