On 31/05/2018 21:43, Richard Shaw wrote:
While trying to build wsjtx 1.9.1 I got a build error. It looks like the long depreciated qt5_use_modules macro has been removed from the release of qt5 in Fedora Rawhide.

I made some simple changes as recommended[1], here's an example snippet:

@@ -1343,7 +1343,8 @@ else ()
       )
   endif ()
 endif ()
-qt5_use_modules (wsjtx SerialPort) # not sure why the interface link library syntax above doesn't work
+find_package(Qt5SerialPort)
+target_link_libraries (wsjtx Qt5::SerialPort) # not sure why the interface link library syntax above doesn't work

 # make a library for WSJT-X UDP servers
 # add_library (wsjtx_udp SHARED ${UDP_library_CXXSRCS})

The find_package stuff could probably go higher up in the CMakeLists.txt but this approach in a couple of places allowed me to build 1.9.1.

Thanks,
Richard
KF5OIM

[1] https://doc.qt.io/archives/qt-5.10/cmake-manual.html

Hi Richard,

this will probably have to be a patch for now as the version of Qt we use on some platforms (5.5) does not have full implicit dependency support for some of the Qt modules, in particular QtSerialPort. I suspect we may be stuck with Qt5.5 for a while, until Ubuntu 16.04 LTS gets to end of life amongst others.

73
Bill
G4WJS.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel

Reply via email to