>
> if ((x[9]&0x80)==1)
> return;
> warning: bitwise comparison always evaluates to false


Nothing really important but I would have appreciated more a warning like
this:

warning: bitwise comparison always evaluates to false, therefore I will
refuse to compile this source code until you carefully read this warning.

73
Nico / IV3NWV



Il giorno mar 8 gen 2019 alle ore 19:49 Joe Taylor <j...@princeton.edu> ha
scritto:

> Thanks, Ashley!  I guess that error has been in qra64.c for a long time,
> without anyone noticing.  ;-)
>
>         -- Joe, K1JT
>
> On 1/8/2019 2:55 AM, Ashley Brighthope wrote:
> > Hi, i noticed during compiling the source of
> >
> > 784f75 master
> >
> >
> https://sourceforge.net/p/wsjt/wsjtx/ci/master/tree/lib/qra/qra64/qra64.c:245
> >
> >
> > if ((x[9]&0x80)==1)
> > return;
> >
> > warning: bitwise comparison always evaluates to false
> >
> > guessing it should be
> >
> > if (x[9]&0x80)
> > return;
> >
> >
> >
> > _______________________________________________
> > wsjt-devel mailing list
> > wsjt-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/wsjt-devel
>
>
> _______________________________________________
> wsjt-devel mailing list
> wsjt-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wsjt-devel
>
_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel

Reply via email to