On 28/09/2020 18:43, Richard Shaw wrote:
On Mon, Sep 28, 2020 at 8:02 AM Bill Somerville <[email protected]
<mailto:[email protected]>> wrote:
On 28/09/2020 13:33, Richard Shaw wrote:
On Mon, Sep 28, 2020 at 7:22 AM Bill Somerville
<[email protected] <mailto:[email protected]>> wrote:
On 28/09/2020 13:13, Richard Shaw wrote:
Looking at building test packages for Fedora and ran into this:
/builddir/build/BUILD/wsjtx-2.3.0-rc1/wsjtx/Transceiver/HamlibTransceiver.cpp:
In member function 'virtual int HamlibTransceiver::do_start()':
/builddir/build/BUILD/wsjtx-2.3.0-rc1/wsjtx/Transceiver/HamlibTransceiver.cpp:612:69:
error: 'HAMLIB_CACHE_ALL' was not declared in this scope
612 | auto orig_cache_timeout = rig_get_cache_timeout_ms
(rig_.data (), HAMLIB_CACHE_ALL);
| ^~~~~~~~~~~~~~~~
Hamlib is from a 4.0 checkout in June:
4.0-0.9.fc33.20200615git779cd69287
Thanks,
Richard
KF5OIM
Hi Richard,
that is a surprise, there should be a configure check for
that. Please reply with the contents of wsjtx_config.h which
you will find at the root of the build tree.
# cat wsjtx_config.h
#ifndef WSJTX_CONFIG_H__
#define WSJTX_CONFIG_H__
#ifdef __cplusplus
extern "C" {
#endif
#define WSJTX_VERSION_MAJOR 2
#define WSJTX_VERSION_MINOR 3
#define WSJTX_VERSION_PATCH 0-rc1
#define CMAKE_INSTALL_DATAROOTDIR "share"
#define CMAKE_INSTALL_DOCDIR "share/doc/WSJT-X"
#define CMAKE_INSTALL_DATADIR "share"
#define CMAKE_PROJECT_NAME "wsjtx"
#define PROJECT_MANUAL "wsjtx-main"
#define PROJECT_HOMEPAGE
"http://www.physics.princeton.edu/pulsar/K1JT/wsjtx.html";
#define PROJECT_MANUAL_DIRECTORY_URL
"http://www.physics.princeton.edu/pulsar/K1JT/wsjtx-doc/";
#define PROJECT_SAMPLES_URL
"http://downloads.sourceforge.net/project/wsjt/";
#define PROJECT_SUMMARY_DESCRIPTION "WSJT-X - Digital Modes for
Weak Signal Communications in Amateur Radio."
#define HAVE_HAMLIB_CACHING 1
Hi Richard,
OK, I see what has happened. There were two attempts to add
caching to the Hamlib API with different symbol names. You have
the Hamlib commit that contained the first attempt. This patch
should resolve the issue:
https://www.dropbox.com/s/e9gnq45byk835ap/wsjtx-2.patch?dl=0
If you are using the combined WSJT-X tarball and CMake script then
merge the contents into the, possibly empty, wsjtx.patch file at
the root of the unzipped tarball, otherwise apply this patch to
your WSJT-X sources:
https://www.dropbox.com/s/e9gnq45byk835ap/wsjtx-2.patch?dl=0
This patch will be in the next release of WSJT-X.
Applied the patch (from build log):
Patch #1 (wsjtx.patch):
+ echo 'Patch #1 (wsjtx.patch):'
+ /usr/bin/patch --no-backup-if-mismatch -p1 --fuzz=0
patching file CMakeLists.txt
patching file Transceiver/HamlibTransceiver.cpp
patching file wsjtx_config.h.in <http://wsjtx_config.h.in>
But same result.
I can just update the Fedora hamlib packages. I was just waiting for
the commits to calm down but Mike is a machine :)
Thanks,
RIchard
Hi Richard,
thanks for the update, clearly I messed up the compatibility fixes in
that patch. I'll checkout the relevant Hamlib version and sort it out
for the next WSJT-X release. You surely won't be the only one to suffer
this issue if I don't fix it.
73
Bill
G4WJS.
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
