Hi Bill,
I realize that is the default. But if they pass in a directory there is
no check if the directory exists. There should be a error in that case.
One reason I'm mentioning this is I'm not sure how much wsprd code is
carried over to other wjst code where it could be a bigger issue.
----
Also, in 'readc2file' the variable definition 'char* c2file[15];' should
not be pointer. It should be ' char c2file[15];'. In the later 'fread'
it should be passed as an address:
nr = fread( &c2file, sizeof(char), 14, fp);
The original is a pointer to a 15 char c-string that doesn't exist.
Fortunately, it is never used. It just eats the filename from the
beginning of the file.
-73 -
*Rud Merriam K5RUD*
/Mystic Lake Software/ <http://mysticlakesoftware.com/>
On 12/2/20 2:45 PM, Bill Somerville wrote:
On 02/12/2020 20:27, Rud Merriam wrote:
I'm doing a deep look at wsprd to learn about the DSP process. In my
testing I found that the directory path of the -a option is not
checking if the directory exists. If the directory does not exist the
program continues but silently fails to create the files that would
go into the directory. It should either fail with a warning message
or create the directory.
--
-73 -
*Rud Merriam K5RUD*
Hi Rud,
there is a default of the current working directory, wsprd should not
be called with a non-existent data directory. Not passing a '-a'
option is acceptable.
73
Bill
G4WJS.
_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
