Hi Mike,

I cannot confirm that anything you mention needs to be fixed.

You mention file 'constants.h', which does not exist. I think you must mean 'constants.f90'.

File constants.f90 defines the constant NMAX to have the value 30*60*12000 -- the size necessary to hold 30 minutes of data samples at 12000 samples per second.

File jt9com.f90 then allocates storage for this many samples in array id2(NMAX) -- just as required.

I do not understand your comment about "his WAV file". What file is this? And what leads you to suggest that NSMAX=6827 is an incorrect value?

        -- 73, Joe, K1JT

On 9/27/2022 5:14 PM, Black Michael via wsjt-devel wrote:
I think this needs to be fixed -- seems lib/jt9com.f90 got out of sync with constants.h

His WAV file also shows that NSMAX may need to be increased to 6912

diff --git a/lib/constants.f90 b/lib/constants.f90
index 36e81c77b..4f39e1aba 100644
--- a/lib/constants.f90
+++ b/lib/constants.f90
@@ -3,3 +3,4 @@
    integer, parameter :: NDMAX=NTMAX*1500 !Sample intervals at 1500 Hz rate
    integer, parameter :: NSMAX=6827       !Max length of saved spectra
    integer, parameter :: MAXFFT3=16384
+  integer, parameter :: RX_SAMPLE_RATE=12000
diff --git a/lib/jt9com.f90 b/lib/jt9com.f90
index 5b2970c05..b653bba75 100644
--- a/lib/jt9com.f90
+++ b/lib/jt9com.f90
@@ -54,6 +54,6 @@
       real(c_float) :: ss(184,NSMAX)
       real(c_float) :: savg(NSMAX)
       real(c_float) :: sred(5760)
-     integer(c_short) :: id2(NMAX)
+     integer(c_short) :: id2(NTMAX*RX_SAMPLE_RATE)
       type(params_block) :: params
    end type dec_data


Debug output where nsps=6912

Starting program: C:\JTSDK64-Tools\tmp\wsjtx-output\qt\5.15.2\2.6.0\Debug\install\bin\jt9.exe -9 -b G -f 700 -F 300 \Users\mdbla\Downloads\220926_104120.wav
[New Thread 23484.0x628c]
[New Thread 23484.0x6ce4]
[New Thread 23484.0x55c8]
[New Thread 23484.0x6bf8]

Thread 1 received signal SIGSEGV, Segmentation fault.
0x000000000041466a in symspec (
    shared_data=<error reading variable: value requires 48338160 bytes, which is more than max-value-size>, k=6912,     trperiod=2.1219957909652723e-314, nsps=6912, ingain=0, blowsidelobes=.FALSE., nminw=1, pxdb=0, s=...,
     df3=8.59003392e+09, ihsym=0, npts8=0, pxdbmax=0,
     npct=<error reading variable: Cannot access memory at address 0x0>)
     at C:\JTSDK64-Tools\tmp\wsjtx\lib\symspec.f90:40
40        if(TRperiod+npct.eq.-999.9) stop             !Silence compiler warning





_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel


_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel

Reply via email to