Hi
I would like to report an issue with the ADIF log
created by WSJT-X. I'm currently using v2.5.4 on
macOS 12.6.
WSJT-X offers to log QSOs by filling in a form
prompt. One of the fields of the form allows to
log the "Tx power". Apparently, the form accepts
any text string entered into this field.
Furthermore, the unmodified text string is used to
create the ADIF log of WSJT-X. This behavior
potentially leads to invalid ADIF files as they do
not conform with the ADIF specifications [1]. For
example a user could enter "10W" or "1kW".
According to the specifications, the "TX_PWR"
field should contain "the logging station's power
in Watts with a value greater than 0". In
addition, the data type of this ADIF field is
"Number", i.e. "a sequence of one or more Digits
representing a decimal number, optionally preceded
by a minus sign (ASCII code 45) and optionally
including a single decimal point (ASCII code 46) ".
I see the following points that could help fixing
the mentioned issue:
* Adding tooltip/instructions for the user to
clarify what data type and value (in what units)
should be entered in the "Tx power" field.
* User input sanitation either for the "Tx power"
field of the QSO log form prompt or before writing
the value entered by the user to the ADIF log
file. One option would be to rejecting the
submission of the form and informing the user in
case a wrong data type has been entered.
Regards
Roman HB9HDN
[1]
https://www.adif.org/313/ADIF_313.htm#QSO_Field_TX_PWR
_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
