Hi,

This patch causes a test failure. Please fix it and attach the patch
to the JIRA issue (And make sure you select "Grant license to ASF for
inclusion in ASF works").

Thanks,
Ruchith

Test report:

  <testcase classname="interop.TestScenario2a" name="testScenario2a"
time="0.045">
    <error message="; nested exception is:
        java.lang.NullPointerException"
type="org.apache.axis.AxisFault">AxisFault
 faultCode: {http://schemas.xmlsoap.org/soap/envelope/}Server.userException
 faultSubcode:
 faultString: java.lang.NullPointerException
 faultActor:
 faultNode:
 faultDetail:
        {http://xml.apache.org/axis/}stackTrace:java.lang.NullPointerException
        at 
org.apache.ws.security.message.token.UsernameToken.getFirstNode(UsernameToken.java:475)
        at 
org.apache.ws.security.message.token.UsernameToken.setPassword(UsernameToken.java:413)
        at 
org.apache.ws.security.message.WSSecUsernameToken.prepare(WSSecUsernameToken.java:136)
        at 
org.apache.ws.security.action.UsernameTokenSignedAction.execute(UsernameTokenSignedAction.java:61)
        at 
org.apache.ws.security.handler.WSHandler.doSenderAction(WSHandler.java:193)
        at 
org.apache.ws.axis.security.WSDoAllSender.invoke(WSDoAllSender.java:170)
        at 
org.apache.axis.strategies.InvocationStrategy.visit(InvocationStrategy.java:32)
        at org.apache.axis.SimpleChain.doVisiting(SimpleChain.java:118)
        at org.apache.axis.SimpleChain.invoke(SimpleChain.java:83)
        at org.apache.axis.client.AxisClient.invoke(AxisClient.java:121)
        at org.apache.axis.client.Call.invokeEngine(Call.java:2784)
        at org.apache.axis.client.Call.invoke(Call.java:2767)
        at org.apache.axis.client.Call.invoke(Call.java:2443)
        at org.apache.axis.client.Call.invoke(Call.java:2366)
        at org.apache.axis.client.Call.invoke(Call.java:1812)
        at 
org.apache.ws.axis.oasis.ping.PingBindingStub.ping(PingBindingStub.java:159)
        at org.apache.ws.axis.oasis.Scenario2a.main(Scenario2a.java:86)
        at interop.TestScenario2a.testScenario2a(TestScenario2a.java:63)

        {http://xml.apache.org/axis/}hostname:doc

java.lang.NullPointerException
        at org.apache.axis.AxisFault.makeFault(AxisFault.java:101)
        at org.apache.axis.client.AxisClient.invoke(AxisClient.java:216)
        at org.apache.axis.client.Call.invokeEngine(Call.java:2784)
        at org.apache.axis.client.Call.invoke(Call.java:2767)
        at org.apache.axis.client.Call.invoke(Call.java:2443)
        at org.apache.axis.client.Call.invoke(Call.java:2366)
        at org.apache.axis.client.Call.invoke(Call.java:1812)
        at 
org.apache.ws.axis.oasis.ping.PingBindingStub.ping(PingBindingStub.java:159)
        at org.apache.ws.axis.oasis.Scenario2a.main(Scenario2a.java:86)
        at interop.TestScenario2a.testScenario2a(TestScenario2a.java:63)
Caused by: java.lang.NullPointerException
        at 
org.apache.ws.security.message.token.UsernameToken.getFirstNode(UsernameToken.java:475)
        at 
org.apache.ws.security.message.token.UsernameToken.setPassword(UsernameToken.java:413)
        at 
org.apache.ws.security.message.WSSecUsernameToken.prepare(WSSecUsernameToken.java:136)
        at 
org.apache.ws.security.action.UsernameTokenSignedAction.execute(UsernameTokenSignedAction.java:61)
        at 
org.apache.ws.security.handler.WSHandler.doSenderAction(WSHandler.java:193)
        at 
org.apache.ws.axis.security.WSDoAllSender.invoke(WSDoAllSender.java:170)
        at 
org.apache.axis.strategies.InvocationStrategy.visit(InvocationStrategy.java:32)
        at org.apache.axis.SimpleChain.doVisiting(SimpleChain.java:118)
        at org.apache.axis.SimpleChain.invoke(SimpleChain.java:83)
        at org.apache.axis.client.AxisClient.invoke(AxisClient.java:121)
</error>



On Jan 5, 2008 8:44 AM, Marcel Ammerlaan <[EMAIL PROTECTED]> wrote:
> And a small fix (forgot to get the password from the callback data as well).
> Supersedes the previous patch.
>
> Regards,
>
> Marcel Ammerlaan.
>
>
>
> On Jan 5, 2008 3:55 AM, Marcel Ammerlaan < [EMAIL PROTECTED]>
> wrote:
> > Hi,
> >
> > I've attached a patch to issue WSS-68 that includes the following:
> > 1) Allow for a PasswordNone option to configure passwordless
> UsernameTokens
> > 2) Allow Password callbacks to also provide the username
> >
> > For this some (small) changes and cleanups were needed, as it is now
> permissable to return 'null' passwords. Checks related
> > to this have been removed (which I think is not a real problem as code
> depending on passwords not being null, will now get a NullPointerException
> instead).
> > Also, it is allowable to always set the identity in the callback handler,
> but I've only tested it for the UsernameToken. Extending it to work for
> Signatures as
> > well seems logical, but I'd first like to hear feedback on a smaller scale
> change before making more changes.
> >
> > I've attached the patch to this mail as well.
> >
> > Regards,
> >
> > Marcel Ammerlaan.
> >
> >
>
>



-- 
http://blog.ruchith.org
http://wso2.org

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to