[
https://issues.apache.org/jira/browse/WSS-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771383#action_12771383
]
Colm O hEigeartaigh commented on WSS-204:
-----------------------------------------
Some comments on the patch...
Could you change the opensaml 1.1 groupId to org.opensaml and the artifactId to
opensaml1? That's where it is in the central maven repo:
http://repo1.maven.org/maven2/org/opensaml/opensaml1/
A "mvn clean install" does not compile, as the central maven repo doesn't seem
to have this dependency: org.opensaml:openws:jar:1.2.2. That will need to make
it in before I can apply the patch.
Some trivial things: the headers need some work...most of the dates are wrong,
there are tabs in the pom file, etc.
Looking at the SAML2TokenProcessor, it follows the previous SAML 1 processor in
adding the result as an unsigned token. Have you given any thought to improving
the logic for adding the token as "signed" or "unsigned" depending on whether
it's a signed assertion or not?
Colm.
> Support validating SAML 2.0 tokens
> ----------------------------------
>
> Key: WSS-204
> URL: https://issues.apache.org/jira/browse/WSS-204
> Project: WSS4J
> Issue Type: New Feature
> Components: WSS4J Core
> Affects Versions: 1.5.8
> Reporter: Thilina Buddhika
> Assignee: Colm O hEigeartaigh
> Fix For: 1.5.9, 1.6
>
> Attachments: wss4j.patch
>
>
> With the patch submitted for Rampart-231, SAML 2.0 support will be available
> for Rampart. That patch only generates SAML 2.0 tokens as per the SAML Token
> Profile 1.1 specification. SAML 2.0 validation support is mandatory for the
> full completion of SAML 2.0 support in Rampart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscr...@ws.apache.org
For additional commands, e-mail: wss4j-dev-h...@ws.apache.org
