On Thursday 16 September 2010 2:16:36 pm Colm O hEigeartaigh wrote: > No, I was just following the patch that was submitted. If it's not > good practice, then I'll revert those changes....I'm guessing it's a > good idea to always version maven plugins then?
Usually yes. If you don't, you kind of end up with semi-unpredictable results as the versions you get will depend on what version of Maven you use for some plugins and whatever the latest is for others. For example, with the compiler plugin, that's a core plugin, so different versions of Maven have it locked down to different versions. If you run with an older version of Maven (like 2.0.9 or something), you would get a different version than with 2.2.1. For non-core plugins, like PMD, you'll end up getting whatever the LATEST is in central when you run maven. THe build may work today, but maybe a new version of PMD gets released tomorrow that requires some new config or something. Build breaks. Dan > > Colm. > > On Thu, Sep 16, 2010 at 12:05 AM, Daniel Kulp <dk...@apache.org> wrote: > > Colm, > > > > I noticed this patch UNLOCKS the version of the PMD, source, compiler and > > other plugins. That's probably a bad idea. Was that intentional? > > > > Dan > > > > On Wednesday 15 September 2010 6:40:30 pm cohei...@apache.org wrote: > >> Author: coheigea > >> Date: Wed Sep 15 22:40:30 2010 > >> New Revision: 997529 > >> > >> URL: http://svn.apache.org/viewvc?rev=997529&view=rev > >> Log: > >> [WSS-241] - Patch applied, thanks. > >> > >> Modified: > >> webservices/wss4j/branches/1_5_x-fixes/pom.xml > >> > >> Modified: webservices/wss4j/branches/1_5_x-fixes/pom.xml > >> URL: > >> http://svn.apache.org/viewvc/webservices/wss4j/branches/1_5_x-fixes/pom. > >> xm l?rev=997529&r1=997528&r2=997529&view=diff > >> ======================================================================== > >> == ==== --- webservices/wss4j/branches/1_5_x-fixes/pom.xml (original) > >> +++ webservices/wss4j/branches/1_5_x-fixes/pom.xml Wed Sep 15 22:40:30 > >> 2010 @@ -149,7 +149,6 @@ > >> <plugin> > >> <groupId>org.apache.maven.plugins</groupId> > >> <artifactId>maven-pmd-plugin</artifactId> > >> - <version>2.4</version> > >> <configuration> > >> <linkXRef>false</linkXRef> > >> <failOnViolation>true</failOnViolation> > >> @@ -173,7 +172,7 @@ > >> <plugin> > >> <groupId>org.apache.felix</groupId> > >> <artifactId>maven-bundle-plugin</artifactId> > >> - <version>1.4.0</version> > >> + <version>1.4.3</version> > >> <extensions>true</extensions> > >> <configuration> > >> <instructions> > >> @@ -186,8 +185,8 @@ > >> > >> <Specification-Version>${pom.version}</Specification-Version> > >> > >> <Export-Package> > >> - org.apache.ws.security.*, > >> - org.apache.ws.axis.security.*, > >> + > >> org.apache.ws.security.*;version="${pom.version}", + > >> org.apache.ws.axis.security.*;version="${pom.version}", > >> </Export-Package> > >> <Import-Package> > >> !org.apache.ws.security.*, > >> @@ -253,7 +252,6 @@ > >> <plugin> > >> <groupId>org.apache.maven.plugins</groupId> > >> <artifactId>maven-compiler-plugin</artifactId> > >> - <version>2.0.2</version> > >> <configuration> > >> <source>1.3</source> > >> <target>1.3</target> > >> @@ -265,7 +263,6 @@ > >> <plugin> > >> <groupId>org.apache.maven.plugins</groupId> > >> <artifactId>maven-source-plugin</artifactId> > >> - <version>2.0.4</version> > >> <executions> > >> <execution> > >> <goals> > >> @@ -280,7 +277,6 @@ > >> <plugin> > >> <groupId>org.apache.maven.plugins</groupId> > >> <artifactId>maven-javadoc-plugin</artifactId> > >> - <version>2.5</version> > >> <executions> > >> <execution> > >> <goals> > >> @@ -295,7 +291,6 @@ > >> <plugin> > >> <groupId>org.apache.maven.plugins</groupId> > >> <artifactId>maven-assembly-plugin</artifactId> > >> - <version>2.1</version> > >> <configuration> > >> <descriptors> > >> <descriptor>assembly/bin.xml</descriptor> > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: wss4j-dev-unsubscr...@ws.apache.org > >> For additional commands, e-mail: wss4j-dev-h...@ws.apache.org > > > > -- > > Daniel Kulp > > dk...@apache.org > > http://dankulp.com/blog > > --------------------------------------------------------------------- > To unsubscribe, e-mail: wss4j-dev-unsubscr...@ws.apache.org > For additional commands, e-mail: wss4j-dev-h...@ws.apache.org -- Daniel Kulp dk...@apache.org http://dankulp.com/blog --------------------------------------------------------------------- To unsubscribe, e-mail: wss4j-dev-unsubscr...@ws.apache.org For additional commands, e-mail: wss4j-dev-h...@ws.apache.org
