Vijay,
As we discussed back in July, I don't think it is correct to expose the type of build to the validators themselves. In fact I don't see the need for validators to know how they were invoked (builder, manually, some other mechanism) at all. This information should be contained within the validation framework. By exposing this information it sounds like the JSP validator is trying to work around some performance problem. Can you explain how the JSP validator benefits from knowing the type of build and why this benefit cannot be realized without exposing this information?
Thanks,
Lawrence Mandel
Software Developer
IBM Rational Software
Phone: 905 - 413 - 3814 Fax: 905 - 413 - 4920
[EMAIL PROTECTED]
| Vijay Bhadriraju <[EMAIL PROTECTED]>
Sent by: [EMAIL PROTECTED] 09/27/2005 05:12 PM
|
|
Api Requirement and Implementation
We got a new requirement today for the validation framework to expose the kind of build that is presently occurring to the validator. The JSP validator was the validator that raised this requirement so it can better handle the situation when an empty uri list is being passed in through the IValidationContext::getURIs() to the validator and the JSP Validator wanted to take an appropriate action based on the build kind that was occurring.
To satisfy this api requirement we have added an new api on IValidationContext :: public int getBuildKind(). This api returns the kind of build that the BuildManager passes to the ValidationBuilder. Now any validator that wants to take an action on a particular kind of build (INCREMENTAL_BUILD or FULL_BUILD or AUTO_BUILD or CLEAN_BUILD) can do so.
Api change effecting existing clients
Any implementer's of IValidationContext need to implement this additional getBuildKind() method and can just return 0 if they are not interested in knowing the build kind. Users of default implementation of the IValidationContext i.e WorkbenchContext will need not have to do anything and just use the api if they need it in for their validator.
These changes are being released to head now.
Thanks,
Regards, Vijay
-------------------------------------------------
Vijay Bhadriraju
Rational Tools, J2EE Tooling
Ph: (919) 486-1898, T/L: 526-1898
Internet: [EMAIL PROTECTED]
-------------------------------------------------_______________________________________________
wtp-dev mailing list
[email protected]
https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________ wtp-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/wtp-dev
