This seems to have caused a problem for us (JPT) as well. Even though
we have an implementation of ReferencedResource (an extension of
TranslatorResourceImpl to be specific), our resource is being unloaded
when our file of interest is closed while dirty and saved. It seems to
be because WorkbenchResourceHelper.isConsistent(ourResource) is
returning false (at first, but on debug, this value does return the
correct value - perhaps a race condition??)
This is a critical loss of functionality for us. And possibly also
related to our bug 208147:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=208147
Paul Fullbright
Oracle Corp.
Eclipse Dali/Java Persistence Tools Development
[EMAIL PROTECTED]
Chuck Bridgham wrote:
Sorry for the late response...
For implementor's of EMF Resource classes not subclassing from
ReferencedResource, I can see how this could have caused a regression.
I can submit a patch for your internal use? (Also move fixes to 2.x
and 3.x?).
Our fix did resolve an issue where we were unloading resources too
aggressively. But I can change this slightly to account for
non-"ReferencedResource" instances.
ReferencedResources have reference counting api's, and are used with
the standard J2EE model api's.
- Chuck
Rational Java EE Tooling Team Lead
IBM Software Lab - Research Triangle Park, NC
Email: [EMAIL PROTECTED]
Phone: 919-254-1848 (T/L: 444)
*"Konstantin Komissarchik" <[EMAIL PROTECTED]>*
Sent by: [EMAIL PROTECTED]
10/24/2007 09:14 PM
Please respond to
"General discussion of project-wide or architectural issues."
<[email protected]>
To
"General discussion of project-wide or architectural issues."
<[email protected]>, Chuck Bridgham/Raleigh/[EMAIL PROTECTED], Jason A
Sholl/Raleigh/[EMAIL PROTECTED]
cc
Subject
RE: [wtp-dev] Question about the fix to Bug 163391
Just to clarify...
We are trying to determine if this is due to our incorrect usage of
the api in question or if the fix for 163391 introduced a regression.
In either case, this has caused a really bad behavioral regression for
us that took a long time to track down. This was partly because we
weren't expecting such a change to be introduced in 1.5.3 and were
focused on finding the cause in our code. In any case, a prompt
attention to help us resolve this would be much appreciated.
Thanks,
- Konstantin
------------------------------------------------------------------------
*From:* [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] *On Behalf Of *Hoi Lam*
Sent:* Wednesday, October 24, 2007 3:59 PM*
To:* [EMAIL PROTECTED]; [EMAIL PROTECTED]
Cc:* [EMAIL PROTECTED]
Subject:* [wtp-dev] Question about the fix to Bug 163391
Hello Chuck and Jason,
I have a question regarding the fix for
_https://bugs.eclipse.org/bugs/show_bug.cgi?id=163391_
The fix has tightened the condition logic to only unload resources
that are “Referenced resource” and not consistent…
Could you elaborate on what is a “referenced resource” please (based
on the code, a “referenced resource” must be an instance of
org.eclipse.wst.common.internal.emf.resource.ReferencedResource).
In my case, I have a resource that is an instance of
org.eclipse.emf.ecore.xmi.XMLResourceImpl, and due to the fix, the
resource no longer gets unloaded when it is outdated. As a result,
the EMF model representing the resource is out of sync when the
resource is modified.
Your feedback and any recommendation for a workaround would be greatly
appreciated. Thank you.
Hoi
Notice: This email message, together with any attachments, may contain
information of BEA Systems, Inc., its subsidiaries and affiliated
entities, that may be confidential, proprietary, copyrighted and/or
legally privileged, and is intended solely for the use of the
individual or entity named in this message. If you are not the
intended recipient, and have received this message in error, please
immediately return this by email and then delete it.
Notice: This email message, together with any attachments, may contain
information of BEA Systems, Inc., its subsidiaries and affiliated
entities, that may be confidential, proprietary, copyrighted and/or
legally privileged, and is intended solely for the use of the
individual or entity named in this message. If you are not the
intended recipient, and have received this message in error, please
immediately return this by email and then delete
it._______________________________________________
wtp-dev mailing list
[email protected]
https://dev.eclipse.org/mailman/listinfo/wtp-dev
------------------------------------------------------------------------
_______________________________________________
wtp-dev mailing list
[email protected]
https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________
wtp-dev mailing list
[email protected]
https://dev.eclipse.org/mailman/listinfo/wtp-dev
