Do I take that as a blessing to use one of these classes? If saw, which one do you recommend?
On Tue, Apr 9, 2013 at 3:09 PM, Chuck Bridgham <[email protected]> wrote: > All of those classes are considered protected internal api in spite of > the internal package name. Changing the namespace would have caused too > much breakage, so decided to keep as is. > > API policy here: > *http://wiki.eclipse.org/WTP_API_Policy*<http://wiki.eclipse.org/WTP_API_Policy> > > > Thanks - Chuck > > Senior Architect, RAD Java EE Tools, WTP PMC Lead > IBM Software Lab - Research Triangle Park, NC > > > > From: Fred Bricon <[email protected]> > To: "General discussion of project-wide or architectural issues." < > [email protected]> > Date: 04/09/2013 05:30 AM > Subject: [wtp-dev] Offline/Local EntityResolver to use? > Sent by: [email protected] > ------------------------------ > > > > Hi, > > When I migrated JBoss Tools JSF m2e connector over to m2e-wtp, I removed > the use of JBoss Tools own DTDResolver [1][2], but didn't replace it by > something equivalent from WTP's API. > > This bug [3], while not exactly related, reminded me of the situation. > Quickly looking for EntityResolver implementations in WTP's code, I > probably missed some of them but I found at least > * org.eclipse.wst.common.componentcore.internal.impl.WTPEntityResolver > * org.eclipse.jst.j2ee.internal.xml.J2EEXmlDtDEntityResolver > * org.eclipse.jst.j2ee.core.internal.plugin.CatalogJ2EEXmlDtDEntityResolver > > All of them are internal classes. Any recommendations on the best way to > proceed here? Should I just fork say, WTPEntityResolver.java into m2e-wtp, > or call wtp's internal class? > > > [1] * > https://github.com/jbosstools/jbosstools-base/blob/master/common/plugins/org.jboss.tools.common.core/src/org/jboss/tools/common/xml/DtdResolver.java#L36 > *<https://github.com/jbosstools/jbosstools-base/blob/master/common/plugins/org.jboss.tools.common.core/src/org/jboss/tools/common/xml/DtdResolver.java#L36> > [2] * > http://git.eclipse.org/c/m2e-wtp/org.eclipse.m2e.wtp.git/tree/org.eclipse.m2e.wtp.jsf/src/org/eclipse/m2e/wtp/jsf/internal/utils/JSFUtils.java#n127 > *<http://git.eclipse.org/c/m2e-wtp/org.eclipse.m2e.wtp.git/tree/org.eclipse.m2e.wtp.jsf/src/org/eclipse/m2e/wtp/jsf/internal/utils/JSFUtils.java#n127> > [3] > *https://bugs.eclipse.org/bugs/show_bug.cgi?id=405245*<https://bugs.eclipse.org/bugs/show_bug.cgi?id=405245> > > Thanks. > > Fred > Bricon<https://github.com/jbosstools/jbosstools-base/blob/master/common/plugins/org.jboss.tools.common.core/src/org/jboss/tools/common/xml/DtdResolver.java#L36> > -- > "Have you tried turning it off and on again" - The IT Crowd > _______________________________________________ > wtp-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/wtp-dev > > > _______________________________________________ > wtp-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/wtp-dev > > -- "Have you tried turning it off and on again" - The IT Crowd
_______________________________________________ wtp-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/wtp-dev
