Thanks, Lars.
IIRC, Eclipse fixes that automatically if you adjust the BREE in the
manifest editor... but not if you sed everything commandline. ;)
On Tue, Dec 19, 2017 at 3:17 AM, Lars Vogel <lars.vo...@vogella.com> wrote:
> Hi Nick,
>
> I think you also need to adjust the classpath setting for the jre of each
> project.
>
> Best regards, Lars
>
> Am 18.12.2017 18:44 schrieb "Nick Boldt" <nbo...@redhat.com>:
>
>> John,
>>
>> Glad you're on board with updating to 1.8.
>>
>> Here's what *I* would do, because I tend to prefer commandline tools over
>> GUI ones.
>>
>> 1. I would start with piping all the manifest files through sed...
>>
>> for m in $(find . -name MANIFEST.MF); do sed -i -e
>> "s#J2SE-1\..#JavaSE-1.8#" -e "s#JavaSE-1\..#JavaSE-1.8#" ${m}; done
>>
>> 2. Run a build to see what breaks with the updated manifests from 1.4,
>> 1.5, 1.6 -> 1.8.
>>
>> (If you don't like sed, there's prolly a way to do the whole thing in
>> Eclipse, but that'll likely have to be done one plugin at a time.)
>>
>> 3. Then fix all the compilation complaints in Eclipse.
>>
>> 4. You'll probably also want to bump all your plugins/features from x.y.z
>> to x.(y+1).z to avoid breaking old consumers.
>>
>> The easiest way for that is to run this:
>>
>> mvn -Dtycho.mode=maven
>> org.eclipse.tycho:tycho-versions-plugin:1.0.0:set-version
>> -DnewVersion=5.6.7-SNAPSHOT
>>
>> But bear in mind that it expects ALL plugins/features to be the same
>> version, and if your project doesn't roll that way, it won't bump
>> everything in the reactor in one fell swoop, so you'll have to run it in
>> each and every plugin folder. Or just edit your MANIFEST.MF and pom.xml
>> files by hand.
>>
>> Nick
>>
>>
>>
>> On Mon, Dec 18, 2017 at 12:50 PM, John J Collier <john.j.coll...@ibm.com>
>> wrote:
>>
>>> I agree that we should try and bump the BREE wherever possible. JEE
>>> Tools for example seems to still be on a BREE of J2SE-1.5, if we could get
>>> that up to 1.8, that would be great.
>>>
>>> Nick, what would have to be done to bump up JEE Tools to 1.8?
>>>
>>>
>>> Regards,
>>>
>>> John Collier
>>> Software Developer, WDT/IBM Cloud
>>> Email: john.j.coll...@ibm.com
>>> Phone: (905)-413-3389 <(905)%20413-3389>
>>>
>>>
>>>
>>> From: Nick Boldt <nbo...@redhat.com>
>>> To: Nitin Dahyabhai <nitin.dahyab...@gmail.com>
>>> Cc: Keith Chong <kch...@ca.ibm.com>, Victor Rubezhny <
>>> vrube...@redhat.com>, "General discussion of project-wide or
>>> architectural issues." <wtp-dev@eclipse.org>
>>> Date: 2017/12/18 10:57 AM
>>> Subject: Re: [wtp-dev] Broken SSE builds due to compilation
>>> error, but only in Hudson (can't reproduce locally)
>>> Sent by: wtp-dev-boun...@eclipse.org
>>> ------------------------------
>>>
>>>
>>>
>>> *wild cheering for dropping support for BREE = J2SE-1.4*
>>>
>>> *waves Team Nitin flag*
>>>
>>> If you're keen to break some more eggs, please have a look at
>>> *https://bugs.eclipse.org/bugs/show_bug.cgi?id=528800*
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.eclipse.org_bugs_show-5Fbug.cgi-3Fid-3D528800&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=I07gjkLnprJfwDAw_Zuz09qr-lCmNNFbki6PG8U3_mY&e=>re:
>>> updating toolchains.xml to the latest JDKs, and maybe removing support for
>>> obsolete BREEs like JDK 1.4 - 1.7.
>>>
>>> Just a thought!
>>>
>>> Nick
>>>
>>>
>>>
>>> On Mon, Dec 18, 2017 at 10:45 AM, Nitin Dahyabhai <
>>> *nitin.dahyab...@gmail.com* <nitin.dahyab...@gmail.com>> wrote:
>>> I intend to bump up the BREE of both SSE core and UI to 1.8 in the
>>> master branch to get us past this once and for all. With the platform
>>> dependencies already there, as long as I can keep the code compliance
>>> itself where it is (it's more a pragmatic choice than a dogmatic one) I
>>> don't see much cause not to.
>>>
>>> -Nitin
>>>
>>> On Dec 18, 2017, at 10:37 AM, Nick Boldt <*nbo...@redhat.com*
>>> <nbo...@redhat.com>> wrote:
>>>
>>> I've been seeing this for about a week now:
>>>
>>> [ERROR] Failed to execute goal
>>> org.eclipse.tycho:tycho-compiler-plugin:1.0.0:compile
>>> (default-compile) on project org.eclipse.wst.sse.ui: Compilation failure:
>>> Compilation failure:
>>> [ERROR] /jobs/genie.webtools/webtools-sourceediting_R3_10/workspace/
>>> core/bundles/org.eclipse.wst.sse.ui/src/org/eclipse/wst/sse/
>>> ui/internal/StructuredTextAnnotationHover.java:[43]
>>> [ERROR] HTMLPrinter.addPageProlog(buffer);
>>> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>> [ERROR] The type java.lang.StringBuilder cannot be resolved. It is
>>> indirectly referenced from required .class files
>>>
>>> Affected jobs:
>>> *
>>> *https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/webtools-sourceediting_R3_10/*
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__hudson.eclipse.org_webtools_view_webtools-5FR3-5F10_job_webtools-2Dsourceediting-5FR3-5F10_&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=bFiWl7UPuSHnif3MgsF3jpvKNbDdT-9BZ6BEdSVPUbE&e=>
>>> *
>>> *https://hudson.eclipse.org/webtools/view/webtools_R3_10/job/WTP-R3_10_Integration/*
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__hudson.eclipse.org_webtools_view_webtools-5FR3-5F10_job_WTP-2DR3-5F10-5FIntegration_&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=-uqQQiucE8LgJiYzpor_8WLUWjcFbNGPy6dwRkTTpqk&e=>
>>>
>>> Anyone have time to investigate why this is failing, and offer a fix? I
>>> tried to have Hudson ignore the workspace settings files, which worked in
>>> the gerrit job but didn't fix the problem in the other jobs.
>>>
>>> Related bug: *https://bugs.eclipse.org/bugs/show_bug.cgi?id=528778*
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.eclipse.org_bugs_show-5Fbug.cgi-3Fid-3D528778&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=ujGxCOVWgF8AZYo51We-xUVIFy2r6WvFntPk_dSmwVQ&e=>
>>>
>>> BTW, are the SSE committers seeing the mail sent to
>>> *wtp-rel...@eclipse.org* <wtp-rel...@eclipse.org>?
>>>
>>> Thanks in advance,
>>>
>>> --
>>> Nick Boldt
>>> Senior Software Engineer, RHCSA
>>> Productization Lead :: JBoss Tools & Dev Studio
>>> IM: @nickboldt / @nboldt / *http://nick.divbyzero.com*
>>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__nick.divbyzero.com&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=otnBYl2wDD3UtCt_dEkng7bOyDuCfhHRRn1YMBjWIfw&e=>
>>>
>>>
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__red.ht_sig&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=IAcMPVb1g5XSO9a-eg2PITnmyNCx6WZTA66628x-Dkg&e=>
>>> *TRIED.
>>> TESTED. TRUSTED.*
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__redhat.com_trusted&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=kMyMyt6brH8GBe6z5vBaFVHv72Dl2vxWGR0CbtAHFtE&e=>
>>> @ @redhatnews
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__twitter.com_redhatnews&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=YrdneqJOCQThUonfHJjBviSFPkCenTupZFDjkkwLT54&e=>
>>> Red Hat
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.facebook.com_RedHatInc&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=fJRthKRhCKEw3YIa_lwcsy8PuhJ1bGAoeNoT1l90gEI&e=>
>>>
>>>
>>>
>>> --
>>> Nick Boldt
>>> Senior Software Engineer, RHCSA
>>> Productization Lead :: JBoss Tools & Dev Studio
>>> IM: @nickboldt / @nboldt / *http://nick.divbyzero.com*
>>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__nick.divbyzero.com&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=otnBYl2wDD3UtCt_dEkng7bOyDuCfhHRRn1YMBjWIfw&e=>
>>>
>>>
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__red.ht_sig&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=IAcMPVb1g5XSO9a-eg2PITnmyNCx6WZTA66628x-Dkg&e=>
>>> *TRIED.
>>> TESTED. TRUSTED.*
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__redhat.com_trusted&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=kMyMyt6brH8GBe6z5vBaFVHv72Dl2vxWGR0CbtAHFtE&e=>
>>> @ @redhatnews
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__twitter.com_redhatnews&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=YrdneqJOCQThUonfHJjBviSFPkCenTupZFDjkkwLT54&e=>
>>> Red Hat
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.facebook.com_RedHatInc&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yleicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=fJRthKRhCKEw3YIa_lwcsy8PuhJ1bGAoeNoT1l90gEI&e=>
>>> _______________________________________________
>>> wtp-dev mailing list
>>> wtp-dev@eclipse.org
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from this list, visit
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.ecl
>>> ipse.org_mailman_listinfo_wtp-2Ddev&d=DwICAg&c=jf_iaSHvJObTb
>>> x-siA1ZOg&r=6q9DBEiC7mYUpxGNnkdhHBpN_7m_NuKsWnDlkmpsTd4&m=yl
>>> eicvggdbs8IhYGQg0-YbWEXXoA1kzbeg042TBSZhU&s=gyQsP-x7tLKC2xqG
>>> xHwQL-cCF72UNnGDskXnZNDIy-0&e=
>>>
>>>
>>>
>>> _______________________________________________
>>> wtp-dev mailing list
>>> wtp-dev@eclipse.org
>>> To change your delivery options, retrieve your password, or unsubscribe
>>> from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>>>
>>
>>
>>
>> --
>>
>> Nick Boldt
>>
>> Senior Software Engineer, RHCSA
>>
>> Productization Lead :: JBoss Tools & Dev Studio
>>
>> IM: @nickboldt / @nboldt / http://nick.divbyzero.com
>> <https://red.ht/sig>
>> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
>> @ @redhatnews <https://twitter.com/redhatnews> Red Hat
>> <https://www.facebook.com/RedHatInc>
>>
>> _______________________________________________
>> wtp-dev mailing list
>> wtp-dev@eclipse.org
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>>
>
> _______________________________________________
> wtp-dev mailing list
> wtp-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>
--
Nick Boldt
Senior Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com
<https://red.ht/sig>
TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
@ @redhatnews <https://twitter.com/redhatnews> Red Hat
<https://www.facebook.com/RedHatInc>
_______________________________________________
wtp-dev mailing list
wtp-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev
