I am not sure how to isolate a fairly thorough rewrite of the Firewatir code followed by merging that Firewatir code with IE Watir's code into one common base. There really just aren't small changes that I can cherry-pick out of that. I understand that time is a limited resource, and reviewing these things is something of a task. I was hoping that my changes would be worth the task, due to the fact that I have fixed a lot of bugs, added a lot of features, and consolidated a lot of redundant/repeated code. It is looking more like that's not going to happen. Maybe it is more appropriate that I fork a full project off from watir to release my work on my own.
On Wed, Jan 27, 2010 at 12:27, Bret Pettichord <[email protected]> wrote: > I have a number of pull requests that unfortunately I have been unable to > review because of other commitments. > > Since mid-December both Jira and the Wiki have been down and this has also > held things up. This problem was fixed this week. > > Ethan, if you can isolate some of the changes that you'd like to have > considered that would facilitate review. > > Bret > > > On Wed, Jan 27, 2010 at 11:03 AM, Ethan <[email protected]> wrote: > >> No on the pull request - at the moment, there is too much that isn't >> entirely resolved about things that have changed in my fork. There is also >> just a lot changed - sufficient quantity that it warrants discussion here I >> think. I'd like to get things resolved in order to get my changes back in, >> hopefully. But, that does not seem to be happening given the lack of much of >> any response. >> My work, I think, greatly improves implementation as far as it goes >> relying on JSSH and WIN32OLE. This may not end up being so useful if >> webdriver is the direction watir is headed. I think that has significant >> shortcomings, but that's another discussion. >> If the developers of watir don't feel that my work is something that will >> be merged back, then my current plan is to fork into a separate project so >> that everything that I have fixed and improved may be available to users. I >> would certainly prefer to see my work available to watir's userbase in watir >> itself, and would still love to hear opinions on this possibility. >> >> -Ethan >> >> >> On Wed, Jan 27, 2010 at 11:35, Željko Filipin < >> [email protected]> wrote: >> >>> On Wed, Jan 27, 2010 at 5:21 PM, Ethan <[email protected]> wrote: >>> > I have fixed a lot of bugs and added quite a bit of good functionality >>> - that doesn't warrant even an answer as to whether any of my work might, >>> possibly, be merged back in? >>> >>> Did you submit pull request(s)? >>> >>> To be honest, I think this is the way to go forward: >>> >>> http://github.com/jarib/watir-webdriver >>> >>> Željko >>> >>> _______________________________________________ >>> Wtr-development mailing list >>> [email protected] >>> http://rubyforge.org/mailman/listinfo/wtr-development >>> >> >> >> _______________________________________________ >> Wtr-development mailing list >> [email protected] >> http://rubyforge.org/mailman/listinfo/wtr-development >> > > > > -- > Bret Pettichord > Lead Developer, Watir, www.watir.com > > Blog, www.io.com/~wazmo/blog <http://www.io.com/%7Ewazmo/blog> > Twitter, www.twitter.com/bpettichord > > > _______________________________________________ > Wtr-development mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/wtr-development >
_______________________________________________ Wtr-development mailing list [email protected] http://rubyforge.org/mailman/listinfo/wtr-development
