On Wed, Feb 17, 2010 at 12:30 AM, Bret Pettichord <[email protected]>wrote:
> Thanks for sharing this. > > 1) Modified locate function to make this_frame as member variable. >> > > I'm confused about this. I don't see any references to it in your code > outside of the method that defines it. > There is! this_frame is being used in function create_rexml_document_object > > >> 2) Added functions html_source, tokenize_tagline, all_tag_attributes, >> element_by_xpath, elements_by_xpath, rexml_document_object, >> create_rexml_document_object, output_rexml_document, xml_escape, >> element_by_absolute_xpath from ie-class and modified accordingly >> >> Probably It would be good to inherit IE class by Frame since most of the >> functionality are same . What do you guys think? >> > > The PageContainer module was created as a place to store functionality that > was common to both IE and Frame. > > In general, I read your code as a monkey patch, rather than as code > changes. Is this your intention? > Nope. Definitely not! This is definitely not the ideal way. I was thinking of making frame class as derived class of IE class. ( I discarded that idea too.) I'll have a look at PageContainer module and see if that can be organized in better way. BTW, your thoughts on how should we do the changes? > > Bret > > -- > Bret Pettichord > Lead Developer, Watir, www.watir.com > > Blog, www.io.com/~wazmo/blog <http://www.io.com/%7Ewazmo/blog> > Twitter, www.twitter.com/bpettichord > > > _______________________________________________ > Wtr-development mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/wtr-development > ------------------------------------------------ Kunal Kumar Email: [email protected] Blog: http://www.kspace.in/blog
_______________________________________________ Wtr-development mailing list [email protected] http://rubyforge.org/mailman/listinfo/wtr-development
