[
http://jira.openqa.org/browse/WTR-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19836#action_19836
]
Alan Baird commented on WTR-452:
--------------------------------
Jarmo -
I think I would be generally for adding a timeout to wait, but I think that it
should be configurable. Just because Rails is opinionated doesn't mean Watir
has to be. This seems like trying to attempt to impose best practices on
testing which isn't a good idea for an automation suite that is applied to all
different kinds of contexts. On principle, Watir should not be opinionated.
This reminds me of a discussion where somebody said a tester should not try to
code around an ID that was not unique on a page. Yes, it's a violation of good
practice, but it seems almost as ignored as it is followed. In this case, or
in others, testers that have "fought the good fight" to get to use Watir in the
first place will have one more point of contention to deal with in talking to
people that might have opposed the adoption of the tool in the first place.
Not everyone has a good relationship with their developers, and sometimes this
is completely out of their control despite their be
st efforts. We should not impose any more restrictions than we have to on our
users that are fighting uphill battles just to be able to use open source
software in the first place.
I don't think that adding a configurable timeout to this function should be a
big deal. I can imagine scenarios where dealing with additional complexity is
not something that should be done in Waitr, but I don't think this is one of
those instances.
Is there a reason why having a configurable timeout would be problematic?
Alan
(PS - sorry if this is on the soapbox a bit, but I think the reasons are still
valid)
> adding timeout to #wait
> -----------------------
>
> Key: WTR-452
> URL: http://jira.openqa.org/browse/WTR-452
> Project: Watir
> Issue Type: Improvement
> Components: Wait
> Affects Versions: 1.6.5
> Environment: all envs
> Reporter: Jarmo Pertman
>
> Currently it is possible that Watir will block forever in it's #wait method
> under some circumstances. There are questions once in a while in the group
> also about the timeout of Watir.
> Unfortunately currently there is no timeout!
> I have a proposal to add a timeout. And make it hardcoded - let's say 5
> minutes. Why hardcoded? Because i think that if your page is unable to load
> in 5 minutes then your page is broken and should be fixed/changed anyway.
> This would be a small indicator to the developers and testers that they
> shouldn't waste so much time of their lives for waiting some bad application
> to render a page.
> Charley proposed to create an issue and let people to vote (not downvote) it!
> So, what do you guys think about making Watir a little as an Opinionated
> Software as Rails tries to be?
> (PS, if your page loads more than 5 minutes and you cannot get yourself
> together to fix it or tell your developers to fix it and you really need to
> have longer timeouts, then you can always monkey-patch #wait. We're talking
> about Ruby where everything is possible, remember?)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.openqa.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Wtr-development mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/wtr-development
