I didn't have the time to look these changes all through, but noticed that it's not possible to just merge all these changes into master. For example eval_in_spawned_process seemed to be unnecessarily complex and is now with a different name in master (http://jira.openqa.org/browse/WTR-449). Also, using sockets and tcpserver seems to be a overkill. So, in short, i think that all changes still needs to be reviewed.
But i have completely different question - why was there a convio branch created in the first place and not merged all useful changes/fixes into master taken into account the fact that it has been possible to do so? Now there's a 500+ lines of code to be reviewed... Jarmo On Sat, Sep 18, 2010 at 7:27 AM, Alan Baird <[email protected]> wrote: > Bret - > I've looked through the monkey patch version and a lot of that stuff looks > like things that have been talked about or other things I don't think people > would have problems with. Particularly, I like the additions to the Element > class (nextsibling and prevsibling especially). I think visible? is already > in there isn't it? > I haven't really thought through all of the implications of :has_cell but > really, it's kind of isolated by using a different "how" strategy that I > don't think it would matter. However, given the discussion we've had about > deprecating :index, I'm not so sure how that would be received. It is a > pretty nifty trick though! > As for the monkey patched version, why wouldn't we just merge the changes > into watir/master? I don't see a lot of objectionable stuff in there. > Alan > > > _______________________________________________ > Wtr-development mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/wtr-development > _______________________________________________ Wtr-development mailing list [email protected] http://rubyforge.org/mailman/listinfo/wtr-development
