I'm going to make another suggestion...
You changed this line:
until @ie.readyState == READYSTATE_COMPLETE do
to this:
until [READYSTATE_COMPLETE,
READYSTATE_INTERACTIVE].include?(@ie.readyState) do
I suggest that, later in the same method, you change:
until doc.readyState == "complete" do
to this:
until ["complete","interactive"].include?(doc.readyState) do
I have encountered the permanent "interactive" state on
http://www.msnbc.msn.com/
BTW, I'm just getting started with Ruby, Watir, and git. If there is a
better way to suggest patches, let me know.
On Tue, Sep 21, 2010 at 3:13 PM, Jarmo <[email protected]> wrote:
> Fixed.
>
> On Tue, Sep 21, 2010 at 9:39 PM, Jarmo <[email protected]> wrote:
> > There is none. Good catch before any actual beta versions. Although
> > i'm not sure how unittests passed (i remember running them before
> > commit and they're not passing currently). Also, looking at the commit
> > itself now it seems that wrong version of the file has been committed
> > and not the one with merged Bret's changes. It seems to me that i've
> > gotten fooled by myself or some of the tools i'm using. I'm not able
> > to find the correct version either. Gonna fix it all asap. If i figure
> > out the reason how it all could happened, i'll let you guys know :)
> >
> > Jarmo
> >
> > On Tue, Sep 21, 2010 at 9:22 PM, Pyron, Robert <[email protected]>
> wrote:
> >> Where is READYSTATE_INTERACTIVE defined? (Other than MSSDK, etc)
> >>
> >> I am running Watir 1.6.5 with Ruby 1.8.7
> >>
> >>
> >>
> >> On Fri, Sep 17, 2010 at 4:17 AM, Jarmo Pertman (JIRA) <
> [email protected]>
> >> wrote:
> >>>
> >>> [
> >>>
> http://jira.openqa.org/browse/WTR-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> >>> ]
> >>>
> >>> Jarmo Pertman closed WTR-446.
> >>> -----------------------------
> >>>
> >>> Resolution: Fixed
> >>>
> >>>
> >>>
> http://github.com/bret/watir/commit/fb60bac5f0686820ebbb2c9263e43d3ea9f802f1
> >>>
> >>> > Watir::IE#wait doesn't finish at certain circumstances
> >>> > ------------------------------------------------------
> >>> >
> >>> > Key: WTR-446
> >>> > URL: http://jira.openqa.org/browse/WTR-446
> >>> > Project: Watir
> >>> > Issue Type: Bug
> >>> > Components: Wait
> >>> > Affects Versions: 1.6.5
> >>> > Environment: All environments.
> >>> > Reporter: Jarmo Pertman
> >>> > Priority: Major
> >>> >
> >>> > Watir::IE#wait method won't finish if:
> >>> > 1) Go to some page with the browser - readystate will be
> >>> > READYSTATE_COMPLETE (4)
> >>> > 1) Open file save as dialog from the browser
> >>> > 2) Either save the file or close the dialog
> >>> > 3) For some reason readystate is READYSTATE_INTERACTIVE (3)
> >>> > Now, if you want to do something with Watir, which issues
> >>> > Watir::IE#wait, then it will block forever.
> >>> > My suggestion would be to also allow READYSTATE_INTERACTIVE.
> >>> > Get the fix from
> >>> >
> http://github.com/jarmo/watir/commit/7df8932946462f9284c63ca045b4fefe76a222d6
> >>>
> >>> --
> >>> This message is automatically generated by JIRA.
> >>> -
> >>> If you think it was sent incorrectly contact one of the administrators:
> >>> http://jira.openqa.org/secure/Administrators.jspa
> >>> -
> >>> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >>>
> >>>
> >>> _______________________________________________
> >>> Wtr-development mailing list
> >>> [email protected]
> >>> http://rubyforge.org/mailman/listinfo/wtr-development
> >>
> >>
> >> _______________________________________________
> >> Wtr-development mailing list
> >> [email protected]
> >> http://rubyforge.org/mailman/listinfo/wtr-development
> >>
> >
> _______________________________________________
> Wtr-development mailing list
> [email protected]
> http://rubyforge.org/mailman/listinfo/wtr-development
>
_______________________________________________
Wtr-development mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/wtr-development
