I think it makes more sense for a user to specify 0 or 1 as the index they want to start at. It also makes the code simpler to deal with (on the watir side - not on the user's side) - adding or subtracting index_offset rather than adding or subtracting (zero_based_indexing ? 0 : 1).
On Wed, Oct 27, 2010 at 12:00, Jarmo <jarm...@gmail.com> wrote: > What's wrong with the very non-obscure boolean as i suggested before? > > If i'd be a newcomer and come to Watir then all those > "indexing_origin", "origin", "base_index" wouldn't make sense to me. > Jari's "index_offset" would be least obscure if i'd stumble it in the > code. > > I'd remove the "use" from my recommendation and put it like > Watir.zero_based_indexing = true > > I don't personally think that using "0" and "1" makes more sense, > especially for the people who don't know the problem of 1-based > indexing itself. Why not make the name and usage of the method > self-explanatory? > > Jarmo > > On Wed, Oct 27, 2010 at 5:53 PM, Bret Pettichord <b...@pettichord.com> > wrote: > > I think that it is easier to understand if the values are 0 and 1, than > true > > and false. I'm happy to put a guard on it to prevent it from being set to > > other values. > > > > Is this easier to understand? > > > > Watir.indexing_origin = 0 > > > > I'm also finding the ability to use Watir.origin in the tests to be quite > > handy and suspect that I'll use the same technique in our test suite as > we > > prepare to convert, which will not be trivial. This really begs to be > noun. > > And Watir.index_base seems to me to be even more obscure. But maybe > that's > > just me? > > > > Bret > > > > > > On Wed, Oct 27, 2010 at 2:50 AM, Jarmo <jarm...@gmail.com> wrote: > >> > >> I'd change #origin to something more explanatory... Since it will be > >> more or less a temporary option since there is plan to make 0 to > >> default in the future then we could have some better explanatory name. > >> Also, why not just make it a boolean? I don't think that someone likes > >> to set it to something else than 0 or 1... so I'd suggest something in > >> the lines of: > >> Watir.use_zero_based_indexing = true > >> > >> Jarmo > >> > >> 2010/10/27 Bret Pettichord <b...@pettichord.com>: > >> > This weekend I started updating Watir so that it could be configured > to > >> > use > >> > either a one or zero-based index. You turn on zero-indexing using this > >> > command: > >> > > >> > Watir.origin = 0 > >> > > >> > I am doing this work right now on a topic branch (I didn't want to > >> > interfere > >> > with the 1.6.7 release) and with your consent will merge it into > master > >> > when > >> > it is complete. > >> > > >> > I have a number of tests working with the origin so far, but there are > >> > lots > >> > of hidden places where this has an effect (iterators, tables). I > expect > >> > this > >> > will be done in a week or two or so. > >> > > >> > Appreciate your comments on this. Work in progress is here: > >> > > >> > http://github.com/bret/watir/commits/zero-index > >> > > >> > > >> > It seems like there is a pending interest in making a release that > >> > removes > >> > support for some deprecated features. That would need to be a 1.7.0 > >> > release > >> > -- to hold to the semantic naming, as I would like. > >> > > >> > I would like like to release the configurable-index-origin feature in > a > >> > release that does not change the default. However, in a later release, > I > >> > think we will want to change Watir to use a zero-based origin. > >> > > >> > > >> > Today, at the office, we were also looking at using Watir with a newer > >> > version of Ruby. We are using Ruby 1.8.6 p287 (IIRC). Not sure > entirely > >> > what > >> > is holding us from using the latest version of 1.8.6 or 1.8.7. Are we > >> > still > >> > running into problems with the Win32 gems? Is anyone using Watir's > >> > showModalDialog support with a newer version of Ruby? Any way, I'd > like > >> > to > >> > see if I can get this sorted out. > >> > > >> > > >> > Bret > >> > > >> > > >> > On Tue, Oct 26, 2010 at 4:11 PM, Charley Baker < > charley.ba...@gmail.com> > >> > wrote: > >> >> > >> >> Agreed, we can do it better, the rolling releases and getting those > >> >> going has been a priority just to make sure we can step it up a bit. > >> >> After so much inactivity, I feel comfortable with the overall > workflow > >> >> again. > >> >> > >> >> Let's prioritize JIRA issues and move them into this next release. > >> >> If anyone would like to step up and help out, feel free to let me > >> >> know. Obviously you're welcome to make pull requests, and edit JIRA > at > >> >> will. We should have a better idea of what's going in the next > release > >> >> in the next day or two. > >> >> > >> >> Cheers, > >> >> > >> >> Charley Baker > >> >> Lead Developer, Watir, http://watir.com > >> >> > >> >> > >> >> > >> >> On Tue, Oct 26, 2010 at 1:57 PM, Jarmo <jarm...@gmail.com> wrote: > >> >> > It took 24 days to release new version. Woho! > >> >> > > >> >> > But i think that we could do it even better :) > >> >> > > >> >> > Agenda for the next version? > >> >> > > >> >> > Jarmo > >> >> > > >> >> > On Tue, Oct 26, 2010 at 10:37 PM, Charley Baker > >> >> > <charley.ba...@gmail.com> wrote: > >> >> >> Hello, everyone! > >> >> >> > >> >> >> Watir 1.6.7 got just released! > >> >> >> > >> >> >> > >> >> >> === General improvements > >> >> >> * added new waiting methods for Watir::Element: #when_present, > >> >> >> #wait_until_present and #wait_while_present (Jari Bakken and Jarmo > >> >> >> Pertman) > >> >> >> * added new waiting methods for Watir::IE and Watir::Firefox: > >> >> >> #wait_until and #wait_while (Jari Bakken and Jarmo Pertman) > >> >> >> * added method #present? for Watir::Element (Jari Bakken and Jarmo > >> >> >> Pertman) > >> >> >> * deprecated old waiting methods in Watir::Waiter which will be > >> >> >> removed in some future version - use Watir::Wait instead (Jarmo > >> >> >> Pertman) > >> >> >> > >> >> >> === IE improvements > >> >> >> * removed Watir::Simple (Željko Filipin) > >> >> >> * #click_no_wait was not working with frame elements. Closes > >> >> >> http://jira.openqa.org/browse/WTR-459 (Jarmo Pertman) > >> >> >> > >> >> >> === Firefox improvements > >> >> >> * get_attribute_value now works with attributes named something > like > >> >> >> "foo-bar" (Alan Shields) > >> >> >> > >> >> >> === Cleanup & Maintenance > >> >> >> * cleaned up repo at GitHub > >> >> >> * merge licenses into one (Željko Filipin) > >> >> >> * Rakefile works now under non-Windows systems too (Alan Shields) > >> >> >> * Removed datahandler.rb (Charley Baker) > >> >> >> > >> >> >> Install it with: > >> >> >> > >> >> >> gem install watir > >> >> >> > >> >> >> And run your existing tests. > >> >> >> > >> >> >> If you're seeing any problems then don't forget to open a ticket > at > >> >> >> JIRA (http://jira.openqa.org/browse/WTR) or fork the project on > >> >> >> GitHub > >> >> >> (http://github.com/bret/watir) and send us a pull request with > the > >> >> >> fix! > >> >> >> If you have any problems installing Watir, then read more detailed > >> >> >> instructions at http://watir.com/installation/ > >> >> >> > >> >> >> Watir Development Team > >> >> >> _______________________________________________ > >> >> >> Wtr-development mailing list > >> >> >> Wtr-development@rubyforge.org > >> >> >> http://rubyforge.org/mailman/listinfo/wtr-development > >> >> > _______________________________________________ > >> >> > Wtr-development mailing list > >> >> > Wtr-development@rubyforge.org > >> >> > http://rubyforge.org/mailman/listinfo/wtr-development > >> >> _______________________________________________ > >> >> Wtr-development mailing list > >> >> Wtr-development@rubyforge.org > >> >> http://rubyforge.org/mailman/listinfo/wtr-development > >> > > >> > > >> > -- > >> > Bret Pettichord > >> > Lead Developer, Watir, www.watir.com > >> > > >> > Blog, www.io.com/~wazmo/blog > >> > Twitter, www.twitter.com/bpettichord > >> > > >> > > >> > _______________________________________________ > >> > Wtr-development mailing list > >> > Wtr-development@rubyforge.org > >> > http://rubyforge.org/mailman/listinfo/wtr-development > >> > > >> _______________________________________________ > >> Wtr-development mailing list > >> Wtr-development@rubyforge.org > >> http://rubyforge.org/mailman/listinfo/wtr-development > > > > > > -- > > Bret Pettichord > > Lead Developer, Watir, www.watir.com > > > > Blog, www.io.com/~wazmo/blog > > Twitter, www.twitter.com/bpettichord > > > > > > _______________________________________________ > > Wtr-development mailing list > > Wtr-development@rubyforge.org > > http://rubyforge.org/mailman/listinfo/wtr-development > > > _______________________________________________ > Wtr-development mailing list > Wtr-development@rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development >
_______________________________________________ Wtr-development mailing list Wtr-development@rubyforge.org http://rubyforge.org/mailman/listinfo/wtr-development
